From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.3210.1587634964413151212 for ; Thu, 23 Apr 2020 02:42:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bp9vG75e; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587634963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GcA7e8760Y4hayYYq0yVhuKIbgQN+9J0a2tOiXXCutE=; b=bp9vG75eekFDM8tzn972yd/XbL8Si+6RVhafMP1jDVYv2KD2helOOdbvr1Ac3Po1MHvXYF g55HqpY8GI11zMVOnw7lS8N0ocMvepVlEg41Ux3rXqFLeJ/8FercHGdQs/BJj44iEnf8uW jsXouDSTYStHdUH9KhI2yJ0vq5TcFLI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-p0HT4Z41MDe6h6skQvhosw-1; Thu, 23 Apr 2020 05:42:40 -0400 X-MC-Unique: p0HT4Z41MDe6h6skQvhosw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D9602F29; Thu, 23 Apr 2020 09:42:39 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-95.ams2.redhat.com [10.36.114.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5269F5D70A; Thu, 23 Apr 2020 09:42:37 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor From: "Laszlo Ersek" To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Jordan Justen , Ard Biesheuvel , Leif Lindholm , Michael Kinney , Andrew Fish , Peter Grehan References: <20200421030955.114850-1-rebecca@bsdio.com> <20200421030955.114850-5-rebecca@bsdio.com> Message-ID: <11ec0993-f602-ea9c-6288-ce2d13f6b205@redhat.com> Date: Thu, 23 Apr 2020 11:42:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/23/20 11:19, Laszlo Ersek wrote: > (10) *However*, in the subsequent patches (#5 and #6), you are > introducing content (PlatformPei and AcpiPlatformDxe) that is under > BSD-2-Clause-Patent. > > Meaning that BhyvePkg needs a License.txt that's similar to > OvmfPkg/License.txt: > > - it should list *two* licenses, > > - the license blocks should be separated visually (e.g. a long line of > "====="), > > - both license blocks should have their SPDX identifiers, > > - the "default" license -- BSD-2-Clause-Patent --should be at the top, > > - the "non-default" license -- namely BSD-2-Clause -- should be at the > bottom, and it should *list* the modules that are covered by it. I'm just realizing that, unfortunately, patches #5 and #6 introduce modules where each module *in itself* is not consistently covered by a single license. In other words, PlatformPei is a mix of BSD-2-Clause-Patent and BSD-2-Clause. So is AcpiPlatformDxe. BUt, I *think* the language seen in "OvmfPkg/License.txt" should accommodate that too. It goes: Some files are subject to the following license, the [...] license. Those files are located in: - [directory] - [directory] It says "some files", and where they are. It doesn't seem to imply that *all* files under those directories are covered by the non-default license. So please just list all those module directories in this (non-default) part of "BhyvePkg/License.txt" that have *at least one* file covered by "BSD-2-Clause". Thanks Laszlo