From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Laszlo Ersek <lersek@redhat.com>,
Michael Kinney <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Leif Lindholm (Nuvia address)" <leif@nuviainc.com>,
Andrew Fish <afish@apple.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: please let's disable the ECC plugin in CI, in its current form
Date: Tue, 8 Dec 2020 08:03:39 +0100 [thread overview]
Message-ID: <11f1e183-fa2b-eae2-43c2-d5150de6b3d6@arm.com> (raw)
In-Reply-To: <5c535e4c-a703-6dab-0067-48d7a3f0c3dd@redhat.com>
On 12/8/20 3:04 AM, Laszlo Ersek wrote:
> Hi All,
>
> in my opinion, the ECC plugin in CI has not been productive or helpful.
> The errors it reports are not convincing, and exceptions are difficult
> to add, or even express. I request that we disable ECC globally for
> edk2, or at least make it controllable through a github PR flag (not
> through CI metafile changes in edk2).
>
> (Metafile changes could be an acceptable way of controlling ECC if (a)
> they didn't have to go through review, (b) if technically such changes
> would take effect in CI even if they were included in the patch series
> subject to the CI run. Then a maintainer could evaluate and
> *immediately* suppress such ECC issues by adding the exceptions as a
> prepended patch, and force-pushing the updated branch to the same open
> PR. But this would remain much inferior to simply disabling ECC, or
> controlling it through a PR label.)
>
+1
--
Ard.
next prev parent reply other threads:[~2020-12-08 7:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 2:04 please let's disable the ECC plugin in CI, in its current form Laszlo Ersek
2020-12-08 7:03 ` Ard Biesheuvel [this message]
2020-12-08 15:38 ` 回复: [edk2-devel] " gaoliming
2020-12-08 18:37 ` Sean
2020-12-10 1:34 ` 回复: " gaoliming
2020-12-10 3:39 ` Sean
2020-12-11 1:10 ` 回复: " gaoliming
[not found] ` <164ED1ABFE90B1B0.9298@groups.io>
2020-12-09 10:24 ` Sean
2020-12-10 8:12 ` Laszlo Ersek
2020-12-10 8:52 ` Laszlo Ersek
2020-12-11 1:13 ` 回复: " gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11f1e183-fa2b-eae2-43c2-d5150de6b3d6@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox