From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: Pierre Gondois <pierre.gondois@arm.com>, <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Michael D Kinney <michael.d.kinney@intel.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg
Date: Tue, 12 Mar 2024 09:47:24 -0700 [thread overview]
Message-ID: <120c7c23-a25e-41ce-a6e6-f43761f696be@quicinc.com> (raw)
In-Reply-To: <20240312091850.2320650-1-pierre.gondois@arm.com>
On 2024-03-12 02:18, Pierre Gondois wrote:
> This patch relies on [1].
>
> Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1],
> move the Chipset/* files to the MdePkg as the Armlib.h relies on
> them.
>
> These patches span over multiple packages as these Chipset/* files
> are relocated to a new directory and include paths must be updated.
I like this!
Traveling this week, so unable to test until Wednesday next week at the
earliest, which I would like to do for something this core before giving
a Reviewed-by. So for now, for the series:
Acked-by: Leif Lindholm <quic_llindhol@quicinc.com>
> [1] https://edk2.groups.io/g/devel/message/111566
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Pierre Gondois (2):
> ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg
> ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg
>
> ArmPkg/Library/ArmExceptionLib/AArch64/AArch64Exception.c | 2 +-
> ArmPkg/Library/ArmExceptionLib/AArch64/ExceptionSupport.S | 2 +-
> ArmPkg/Library/ArmExceptionLib/Arm/ArmException.c | 2 +-
> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 2 +-
> ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 2 +-
> ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 2 +-
> ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +-
> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibConvert.c | 2 +-
> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibCore.c | 2 +-
> ArmPkg/Library/ArmMmuLib/Arm/ArmMmuLibUpdate.c | 2 +-
> ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 2 +-
> ArmPlatformPkg/PrePeiCore/AArch64/Helper.S | 2 +-
> ArmPlatformPkg/PrePi/AArch64/ArchPrePi.c | 2 +-
> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +-
> ArmVirtPkg/PrePi/AArch64/ArchPrePi.c | 2 +-
> {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h | 2 +-
> .../Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h | 0
> .../Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h | 2 +-
> .../Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h | 0
> MdePkg/Include/Library/ArmLib.h | 4 ++--
> 20 files changed, 19 insertions(+), 19 deletions(-)
> rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64.h (94%)
> rename {ArmPkg/Include/Chipset => MdePkg/Include/AArch64}/AArch64Mmu.h (100%)
> rename ArmPkg/Include/Chipset/ArmV7.h => MdePkg/Include/Arm/AArch32.h (95%)
> rename ArmPkg/Include/Chipset/ArmV7Mmu.h => MdePkg/Include/Arm/AArch32Mmu.h (100%)
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116692): https://edk2.groups.io/g/devel/message/116692
Mute This Topic: https://groups.io/mt/104881290/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-12 16:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 9:18 [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg PierreGondois
2024-03-12 9:18 ` [edk2-devel] [PATCH 1/2] ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h " PierreGondois
2024-03-12 9:18 ` [edk2-devel] [PATCH 2/2] ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h " PierreGondois
2024-03-12 16:47 ` Leif Lindholm [this message]
2024-03-12 16:53 ` [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files " Michael D Kinney
2024-03-13 10:26 ` PierreGondois
2024-03-27 8:52 ` PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=120c7c23-a25e-41ce-a6e6-f43761f696be@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox