From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by mx.groups.io with SMTP id smtpd.web10.65586.1643814184135554442 for ; Wed, 02 Feb 2022 07:03:04 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=uSlvy9RY; spf=pass (domain: quicinc.com, ip: 199.106.114.38, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1643814184; x=1675350184; h=message-id:date:mime-version:subject:to:references:from: in-reply-to; bh=FJRuyPqc3a6kDkmBuy2fRWb07J+uecAEy8ugZ+o+wNo=; b=uSlvy9RYFKnN7crCQa7W7FFLIaF7pSbfhndA5A6eVpoROVEjje5SSqMc iFSx4Za+b+QFyY1XQlr6usOPFQ2EwQQrEE2/9dCNl4FAzrRpTetUxnwwT 8HmTJozW4gK9MiLtsh5FKA1JyvpIjefgi3OjXEuioDk/Xr3FasFv7Fmzl 0=; Received: from unknown (HELO ironmsg01-sd.qualcomm.com) ([10.53.140.141]) by alexa-out-sd-01.qualcomm.com with ESMTP; 02 Feb 2022 07:03:03 -0800 X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg01-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2022 07:03:03 -0800 Received: from [10.110.3.55] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.922.19; Wed, 2 Feb 2022 07:03:02 -0800 Message-ID: <121ca130-f57a-8e6f-3fac-03af53453640@quicinc.com> Date: Wed, 2 Feb 2022 08:03:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [edk2-devel] [PATCH v3 1/3] DynamicTablesPkg: Add Memory32Fixed function To: , , PierreGondois , Alexei Fedorov , "Leif Lindholm" , nd References: <20220113164052.20841-1-quic_rcran@quicinc.com> <20220113164052.20841-2-quic_rcran@quicinc.com> <5e24bff1-5aeb-608f-0439-ef677e4fe9b4@arm.com> From: "Rebecca Cran" In-Reply-To: <5e24bff1-5aeb-608f-0439-ef677e4fe9b4@arm.com> Return-Path: quic_rcran@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Type: multipart/alternative; boundary="------------m2MOoI3v4FmqECB0j25jmNmx" Content-Language: en-US --------------m2MOoI3v4FmqECB0j25jmNmx Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2/2/22 07:52, Sami Mujawar wrote: >> +AmlCodeGenRdMemory32Fixed ( >> + BOOLEAN IsReadWrite, >> + UINT32 Address, >> + UINT32 RangeLength, >> + AML_OBJECT_NODE_HANDLE NameOpNode, >> + AML_DATA_NODE_HANDLE *NewMemNode >> + ) >> +{ >> + EFI_STATUS Status; >> + AML_DATA_NODE *MemNode; >> + EFI_ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR RangeDesc; >> + >> + RangeDesc.Header.Header.Byte = ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR; >> + RangeDesc.Header.Length = 0x09; > [SAMI] Would it be ok if I change the above line to > RangeDesc.Header.Length = sizeof > (EFI_ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR) - > sizeof (ACPI_LARGE_RESOURCE_HEADER); > before merging? > [/SAMI] Yes, that would be good. Thanks. Rebecca Cran --------------m2MOoI3v4FmqECB0j25jmNmx Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

On 2/2/22 07:52, Sami Mujawar wrote:

+AmlCodeGenRdMemory32Fixed (
+  BOOLEAN                 IsReadWrite,
+  UINT32                  Address,
+  UINT32                  RangeLength,
+  AML_OBJECT_NODE_HANDLE  NameOpNode,
+  AML_DATA_NODE_HANDLE    *NewMemNode
+  )
+{
+  EFI_STATUS                                     Status;
+  AML_DATA_NODE                                  *MemNode;
+  EFI_ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR  RangeDesc;
+
+  RangeDesc.Header.Header.Byte = ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR;
+  RangeDesc.Header.Length      = 0x09;

[SAMI] Would it be ok if I change the above line to
RangeDesc.Header.Length = sizeof (EFI_ACPI_32_BIT_FIXED_MEMORY_RANGE_DESCRIPTOR) -
sizeof (ACPI_LARGE_RESOURCE_HEADER);
before merging?
[/SAMI]

Yes, that would be good.

Thanks.

Rebecca Cran

--------------m2MOoI3v4FmqECB0j25jmNmx--