From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.80]) by mx.groups.io with SMTP id smtpd.web10.72648.1670937117783916598 for ; Tue, 13 Dec 2022 05:11:58 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Q7m3p7yR; spf=pass (domain: arm.com, ip: 40.107.21.80, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CcLKuEBqQrM2NegMKBBafTLIx4DM7UDbdFbMn2uyWI=; b=Q7m3p7yRDcEvhoODiz603NgXiirP6s5qhy9Im8JMeUrOd1AYj+81shRqryHR270ssqNL1qX1Q8xq9KEMavc7jDJ1KAf8jjz1hyv+wi9L1XhrwV6jbyYJa0XNr+HZH8tmBXShIWRA4Y2KToVCHp2CUtvHVFySp9piYyuCU7gyHPk= Received: from DU2PR04CA0319.eurprd04.prod.outlook.com (2603:10a6:10:2b5::24) by GV1PR08MB8105.eurprd08.prod.outlook.com (2603:10a6:150:96::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.7; Tue, 13 Dec 2022 13:11:52 +0000 Received: from DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::dc) by DU2PR04CA0319.outlook.office365.com (2603:10a6:10:2b5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8 via Frontend Transport; Tue, 13 Dec 2022 13:11:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT005.mail.protection.outlook.com (100.127.142.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5901.21 via Frontend Transport; Tue, 13 Dec 2022 13:11:52 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Tue, 13 Dec 2022 13:11:52 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 950781f8b8397f93 X-CR-MTA-TID: 64aa7808 Received: from 5e8a84a7329e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 824EE53A-AB99-4D55-BD3B-6B8552CA722C.1; Tue, 13 Dec 2022 13:11:40 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5e8a84a7329e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Dec 2022 13:11:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WjYGFGvmvY5Oj3qvtppmHUwfi3MAUdDJfhuIn029WiuSGj/M0pvFOP424RA1KuSUmEMCFHV4DEXHEIF+jnbrmeBGpffW/9wq3iwyC+74fjetJO/xJkYb99IeXeDjFeLW7hvsIgIMn7rHLtENAFfEnV5hnu8+ROTsO0eXWP88NooQlJ5IRh49Ww48Uh8H7TJPenyQLcogCFTKOIsyrQdME825Yipr/dIYErSI1YYXGblEwIkqFoHcXtszKhJROPqW6vOTCedt3B9XCIcEtRD4qfm1MA0objH4yirSULMvA7wn971DAD2F958tVwip++3KSv6cD+uKdmsml3qlMjZn4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4CcLKuEBqQrM2NegMKBBafTLIx4DM7UDbdFbMn2uyWI=; b=KVAB6kr+NO1dE7b1Z5LXQxqX7FqdQQEuLPWZROxa8Tilxx/bpG/7gqib9Ivi4n6ROSm2A2icqFmlieg4OxNhkobkx1Cj77cbcI01ODobI9xDw/MFEWTFbbKi9jPwp3XLSK43sqUvbdhZdja2T/T7jG7WYQhhGHbnjHS16VSInSe6YhvZlCCEAFvHmrfp5DV38oxcpmn3hYs7bDaODOq0SYgWuW4R/zNPJst89jHyMX3Y54BP0mWOLIyU+lWMQbMppOy1N2kDVI9ANDjROzdqhD3xY3AWYRatBVmxp2L6W/SVd0h53yon4tvGlJjFk3lKP43akRI7iANGn4NTuIxuJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4CcLKuEBqQrM2NegMKBBafTLIx4DM7UDbdFbMn2uyWI=; b=Q7m3p7yRDcEvhoODiz603NgXiirP6s5qhy9Im8JMeUrOd1AYj+81shRqryHR270ssqNL1qX1Q8xq9KEMavc7jDJ1KAf8jjz1hyv+wi9L1XhrwV6jbyYJa0XNr+HZH8tmBXShIWRA4Y2KToVCHp2CUtvHVFySp9piYyuCU7gyHPk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB8472.eurprd08.prod.outlook.com (2603:10a6:10:404::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.8; Tue, 13 Dec 2022 13:11:37 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::eca2:349c:4dbf:7f10%9]) with mapi id 15.20.5924.010; Tue, 13 Dec 2022 13:11:37 +0000 Message-ID: <121eee9e-8dee-d8cd-2b2c-4b2d7aa825fb@arm.com> Date: Tue, 13 Dec 2022 13:11:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [edk2-devel] [edk2-platforms][PATCH V3 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID To: devel@edk2.groups.io, Sahil CC: Ard Biesheuvel , Leif Lindholm , Samer El-Haj-Mahmoud , nd References: <20221208120707.840656-1-sahil@arm.com> <172ED26EFF10A09A.9474@groups.io> From: "Sami Mujawar" In-Reply-To: <172ED26EFF10A09A.9474@groups.io> X-ClientProxiedBy: LO4P123CA0292.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::9) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB8472:EE_|DBAEUR03FT005:EE_|GV1PR08MB8105:EE_ X-MS-Office365-Filtering-Correlation-Id: 214752d8-d9a8-4085-5e77-08dadd0b99db x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xSrk5QZ8Z2x3QDK38eKZtcUNis93fGzfC/p9qkwVUOmmcKHPLe1aXIVuuP7Qi+uhbq5+2E4NRqdRScaNamNZdA/bStfev+0DkeDlNBPScMAkEcMcC6Zv91tVv9gBunKgSjNccW8qyOysqSq+xu3ePlTXJ6vWCWNcFDYig1vloD3GTb7pzCchs+vYdnxDZppCZ0yRGp8wLnsk2LlKSAiK+fa1pt7DESKfQ+dfc0pg9GmzdYR1Jc14z5EV7Po3912xev6M3r2VQZ80YIDSOo56rr8AVpV7prl8uAjC5WBUPAO3XeATEfuqWy4bdEmjZ4C5nIZuUVMSjnPh3VlGIRZ8wX1QbFhDQ4tUdDn2QTFJwLoW055Xsv/5T+ggxcYBrQcG8JYy/OrTigCWe4j7bYuUDG5IMFq47k+A/zdQ/Y0+iPsWzTLUlNTOWQucqTX52SiVTkS+3Pf6B8C8IjqHSpVA1aIBozTPNO1PyyjJr8QopOmQU5vs7IciIEoKZ4r9TL1GGwQtogX/xtI0s1m0JybzP1esOI2TzxrMzeE2KSchUjAd91i+DCtcFfdNqtTcsc1uEaH2d3RrS6hGNtKFLFZ7/C8h6xFYchC8t6XPkVrf6KOigDKERa0qwpBOjgCiyCeGNwajqrRAjDg3IGHp4f3gbwJXhEFwLmWqEJI7OENacM+yn3XZGRDNYv4U5ig08tBNj8ePYLy57+VGHfF1rAsUGxeZxo8EhcZZtSe18qUuOz67x7CgQ+bd8PLmgZSaGjJAtMp+EGoYq+iGjs72/YhM1GbvcgEMbA7R3hnFC/u8BP4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199015)(4326008)(66556008)(66946007)(8676002)(186003)(6862004)(8936002)(83380400001)(53546011)(5660300002)(2616005)(36756003)(6506007)(66476007)(37006003)(966005)(478600001)(6636002)(41300700001)(26005)(31696002)(6512007)(54906003)(6486002)(316002)(86362001)(31686004)(15650500001)(2906002)(66899015)(38100700002)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8472 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3a6bd388-170f-4a3a-12bc-08dadd0b90b5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GCW5sCu1obwo30ieWHm2PDP9z0djubtgIWP77V9Itn573+rhGqORsDlG9ZQ2Hg5Urrwo9rXFDbpXZbynIMMmLOKl+fWsanvOIfwouFISWcpqj8VRwxaaMldnfgBwK/g+qFMJU0vxWVe/DiYFFKlgcTpMvsIHjV9rl7UwcC5jWKXtN1aBUZ4JEOjHX6a6Q5LxperPjnVGXhqxPd353jeuI60iW7SI4SYe+ONqMob0iM4cV1f94opoq7IYNEgDfliPRlVuEPMoj74NJdeYjpQD0Z5qcP2CazmrsZX8Z7Bl3wD41EZYEWqCQlE1GrS5jZGIbeedeOkUvj7nz1UajgahJfdsfuHWxiNswWtY3eFrVwfybjR7bkHLDe9oYY3HZo0VzE9FPcpGZ4Rfi8ABQ42VSPlgXXgQ7bW0ofFDFZ2v21kQIL/05RN9Lz8ZPB6K4ekg9zqj/B3xkvt7EuV5xvZYG9QFvSphEblFr5sKlX4QdbqaSQ4W/ke8RXP1vt4OMjaXzE3rBjoe3kd8BtNl3Ea8HmVy0c6eYWjOxcYpowEcAU7bihAJoIP6ogOpE08nfJiz4oQGVgXZ3q2E0bTEh6wOQK3ImXM2/lvIVI+SlWmVRFibx1+VA1QVcFgTDkijbFIauhn0+T9FPY0hoASnjrQkXoqP4GJbuIyu3QMbs2Iiaq1JlLEgxj6RnGVKTxMR+sRurVKWUfyCO4gHYZ0Etk2CNJmesgx+hPcxzyariRryphX6IAN+z0sKeMcqIMa+EIZmcMzGVHUI/JdAi/28KFX2SvmIs8CwgpWxxYbRd+tWAxk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199015)(40470700004)(46966006)(36840700001)(6486002)(26005)(6512007)(53546011)(6506007)(31686004)(186003)(966005)(66899015)(478600001)(8936002)(40460700003)(4326008)(8676002)(86362001)(36756003)(37006003)(83380400001)(54906003)(6636002)(47076005)(2616005)(6862004)(2906002)(82310400005)(316002)(336012)(70586007)(41300700001)(31696002)(15650500001)(44832011)(82740400003)(70206006)(40480700001)(81166007)(36860700001)(5660300002)(356005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 13:11:52.1859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 214752d8-d9a8-4085-5e77-08dadd0b99db X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8105 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Merged as f0385722832d..df870c7beaee Thanks. Regards, Sami Mujawar On 08/12/2022 12:51 pm, Sami Mujawar via groups.io wrote: > HI Sahil, > > Thank you for the updated patch. > These changes look good to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar > > =EF=BB=BFOn 08/12/2022, 12:07, "sahil" wrote: > > The PNP ID 0x0A09 used for CCIX host bridge in the current code is > not defined in any specification and is therefore incorrect. > > Also, there is no need for a separate ID for CCIX host bridge, > for the following reasons: > > 1. CCIX doesn't have any host specific requirements/ingredients as s= uch. > 2. CCIX protocol messages flow over regular PCIe. > 3. CCIX devices and root ports are natively discovered using the CCI= X DVSEC. > > Therefore, reuse PCIe PNP ID for CCIX. > > Signed-off-by: sahil > --- > > Notes: > v3: > - added more info regarding the change in commit message [Sami M= ujawar] > v2: > - removed licence fix, to be pushed in separate patch [Leif Lind= holm] > > Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib= .c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciH= ostBridgeLib.c b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHost= BridgeLib.c > index 1f38f654a8ce..6a154d771126 100644 > --- a/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBrid= geLib.c > +++ b/Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBrid= geLib.c > @@ -65,8 +65,8 @@ STATIC EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mEfiPciRoot= BridgeDevicePath[ROOT_COMPLEX_ > (UINT8)(sizeof (ACPI_HID_DEVICE_PATH) >> 8) > > } > > }, > > - EISA_PNP_ID(0x0A09), // CCIX > > - 0 > > + EISA_PNP_ID(0x0A08), // CCIX > > + 1 > > }, > > { > > END_DEVICE_PATH_TYPE, > > -- > 2.25.1 > > > > >=20 > >