From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81])
 by mx.groups.io with SMTP id smtpd.web11.1282.1588190298650605325
 for <devel@edk2.groups.io>;
 Wed, 29 Apr 2020 12:58:18 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MlE0vJHT;
 spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1588190297;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=BJ6XFMQTvRVXVwj+Nab04SGDzanOCpSgd2LP2SfDBYw=;
	b=MlE0vJHTt3rE4TYbA9rdkvUDde5zrWm6smxZOxMeUNYSWKpvYqjVixrtf2lBlNBwPEf3Bb
	JMtP/TJ3shm9S7p0+6xKRha1rxyYe4yX+qseMnWVBJj0KHaUNkI8cF690ltYE9r+2FuztY
	nyH3ZKdJQrr59UQLfRQMNZ/FyeBakJk=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-315-BcG5KAdAP2CNX6j0H2XBTQ-1; Wed, 29 Apr 2020 15:58:10 -0400
X-MC-Unique: BcG5KAdAP2CNX6j0H2XBTQ-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 91BB11895958;
	Wed, 29 Apr 2020 19:58:09 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-1.ams2.redhat.com [10.36.114.1])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 0318B196AE;
	Wed, 29 Apr 2020 19:58:08 +0000 (UTC)
Subject: Re: [edk2-devel] [edk2-discuss] Best Known Methods for avoiding sending abnormal patch
To: devel@edk2.groups.io, guomin.jiang@intel.com
References: <DM6PR11MB29559E6FD2B44E57B29714CD9DAC0@DM6PR11MB2955.namprd11.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <1222fc3b-f830-018f-1b87-502237d6d92a@redhat.com>
Date: Wed, 29 Apr 2020 21:58:08 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <DM6PR11MB29559E6FD2B44E57B29714CD9DAC0@DM6PR11MB2955.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/28/20 13:30, Guomin Jiang wrote:
> Hi All,
> 
> I encounter a error recently, and it will result in abnormal patch, abnormal CI build and abnormal edk2-devel message.
> 
> You can run ``` git config sendemail.transferencoding 8bit``` to avoid the error.
> 
> The detail information as below,
> When I ready a patch and send it to devel@edk2.groups.io<mailto:devel@edk2.groups.io>, will see below abnormal picture.
> 
> From Mail:
> [cid:image001.png@01D61D85.07F968D0]
> 
> From groups.io
> [cid:image002.png@01D61D86.BD272250]
> 
> From CI:
> [cid:image003.png@01D61D86.BD272250]
> 
> The defect happened because of CR+LF is keep in patch and will keep in mail, it seem that the CI or groups system haven't dispose it correctly.
> 
> I get the answers from https://stackoverflow.com/questions/6289001/git-am-format-patch-control-format-of-line-endings, and bit8 can avoid unnecessary CR when send email. It explain the history why import the option as well.
> 
> https://git-scm.com/docs/git-send-email provide the usage for the option.
> 
> Help it is useful for yours

Yes, please refer to edk2 commit a5abd9cc2ceb ("BaseTools/Scripts: Add
sendemail.transferEncoding to SetupGit.py", 2019-12-24).

$ git show -b a5abd9cc2ceb

Thanks
Laszlo