From: "Ni, Ray" <ray.ni@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation
Date: Fri, 14 May 2021 17:04:22 -0700 [thread overview]
Message-ID: <12259.1621037062277250978@groups.io> (raw)
In-Reply-To: <ee749782-0e71-1082-3fd7-4b06bff5dddb@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 954 bytes --]
Laszlo,
Do you think that another API is also needed: GetPhysicalAddressWidth() that returns number 36/52?
physical address width is needed by (besides those that rely on the width for mask calculation):
UefiCpuPkg\CpuMpPei\CpuPaging.c
UefiCpuPkg\PiSmmCpuDxeSmm\X64\PageTbl.c
MdeModulePkg\Core\DxeIplPeim\X64\VirtualMemory.c
MdeModulePkg\Universal\Acpi\S3SaveStateDxe\AcpiS3ContextSave.c
MdeModulePkg\Universal\CapsulePei\UefiCapsule.c
MdePkg\Library\SmmIoLib\SmmIoLib.c
OvmfPkg\XenPlatformPei\MemDetect.c
UefiCpuPkg\Universal\Acpi\S3Resume2Pei\S3Resume.c
UefiPayloadPkg\UefiPayloadEntry\X64\VirtualMemory.c
GetPhysicalAddressMask() can call GetPhysicalAddressWidth().
Since it's a large-scale change but the SMM high MMIO access bug is critical/urgent, I prefer to firstly push this bug fix change and then work on the new APIs.
https://bugzilla.tianocore.org/show_bug.cgi?id=3394 was submitted to capture this.
[-- Attachment #2: Type: text/html, Size: 1062 bytes --]
next prev parent reply other threads:[~2021-05-15 0:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 4:53 [PATCH] UefiCpuPkg/PiSmmCpu: Remove hardcode 48 address size limitation Ni, Ray
2021-05-13 3:32 ` Dong, Eric
2021-05-14 10:55 ` [edk2-devel] " Laszlo Ersek
2021-05-15 0:04 ` Ni, Ray [this message]
2021-05-16 1:39 ` Laszlo Ersek
2021-05-18 7:51 ` Ni, Ray
2021-05-18 18:42 ` Laszlo Ersek
2021-05-20 4:28 ` Ni, Ray
2021-05-20 7:50 ` Laszlo Ersek
2021-05-20 11:11 ` Michael Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12259.1621037062277250978@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox