Re: [edk2-devel] [PATCH v1 2/6] ArmVirtPkg: Add Platform CI and configuration for Core CI

["Sean" <sean.brogan@microsoft.com>]

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

Ard/Laszlo,

On the topic of Package files.
1. The *.ci.yaml is designed to be at the root of the package and this follows all other Core ci usage.  The Core CI will only look for this file at the root as of now.
2.  The PlatformBuild.py file is exactly like a build.bat or build.sh file found in many platform packages.  This file is relevant for local dev as it will build the package and should support the feature set of the platform.  I would hope that the package maintainers would continue to update this file to match the features of their package otherwise CI will become less and less relevant overtime.  Thus I think it belongs in the same place as build.sh.  The only other pattern we could follow is a ".pytools" folder like for Core CI.  But again unless you strongly disagree I would prefer the first.
3. The readme file...You tell me where?  Or it could be combined with the existing readme.md file?
4. The iasl ext_dep file.  I could see this moving deeper into the package.  Where would you like it? This file is an external dependency to control the version of iasl used on this platform.  It should be kept current with what the platform expects for iasl usage.

Anyway, I need more actionable feedback if you don't agree with the above.

On the forward slashes and typo.  I agree and will get them in the next version.   Thanks for the review.

Thanks
Sean

[-- Attachment #2: Type: text/html, Size: 1568 bytes --]