From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 385E97803CE for ; Mon, 11 Dec 2023 16:22:16 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=hkqeyu2/GwCMSsAt8X6ZBi+wAX1z5lUe/9wZ1oS/xPk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702311734; v=1; b=fbYYYPyeaosconymkfuzAyFORbh8CaiZvM2E6cgks5wjXEYfANzXEXmqf0+M/+MRVl/oKej+ vrdXh2/OQmtigILgp6cbop2pA/c7sE/7GYUFo5qte16KiWx5Q0ELhVjD2CnQte2DWjRvgJxOpnY pZj5yghr13zLDGZ2Vu4v2Dt8= X-Received: by 127.0.0.2 with SMTP id TdKMYY7687511x02b2pr4aSq; Mon, 11 Dec 2023 08:22:14 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.12613.1702311734269178297 for ; Mon, 11 Dec 2023 08:22:14 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-x7zo7AcgNkCjH6W2m9r98A-1; Mon, 11 Dec 2023 11:22:11 -0500 X-MC-Unique: x7zo7AcgNkCjH6W2m9r98A-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27B591C068D3; Mon, 11 Dec 2023 16:22:11 +0000 (UTC) X-Received: from [10.39.194.43] (unknown [10.39.194.43]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B817C15968; Mon, 11 Dec 2023 16:22:10 +0000 (UTC) Message-ID: <12387048-80bf-87db-c15e-55583678863f@redhat.com> Date: Mon, 11 Dec 2023 17:22:08 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] BaseTools/tools_def: Disable unneeded-internal-declaration warning in CLANGPDB To: Mike Beaton Cc: devel@edk2.groups.io, Ard Biesheuvel , Ard Biesheuvel References: <20231210101859.19198-1-mjsbeaton@gmail.com> <9b333ba1-7ce6-5be7-6482-3aadef7f1973@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jcudFuE6Dh0yeTBexYCBHXYrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fbYYYPye; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 12/11/23 16:18, Mike Beaton wrote: > I believe this would be logically wrong, as the other versions still > wouldn't compile if you changed the relevant debug Pcds. (Which are > logically independent of the compile and link options - e.g. what if for > some reason you wanted to single step with the Debug Pcds set to > disabled, in a NOOPT build?) I don't think that use case exists in practice. Anyway, my suggestion is based on prior art: I *think* we ask gcc to whine about unused local variables in RELEASE builds only, too. See commits 20d00edf21d2 ("BaseTools/GCC: set -Wno-unused-but-set-variables only on RELEASE builds", 2016-03-25) and 8b6366f87584 ("BaseTools/GCC: set -Wno-unused-const-variable on RELEASE builds", 2017-09-08). ... TBH I don't understand the current state of "-Wno-unused-but-set-variables" and "-Wno-unused-const-variable" between X64 and AARCH64, considering the DEBUG target. Today, DEBUG_GCC5_AARCH64_CC_FLAGS disables these warnings, but DEBUG_GCC5_X64_CC_FLAGS doesn't, even though *both* macros specify -flto. Compare commit 06c8a34cc4bc ("BaseTool/tools_def GCC5: enable optimization for ARM/AARCH64 DEBUG builds", 2017-12-08) -- I don't understand why "-flto" had to be accompanied by "-Wno-unused-but-set-variable -Wno-unused-const-variable" in that commit. In brief, IA32 and X64 prior art supports my suggestion to shut up the warning only for RELEASE (for CLANGPDB too), but ARM/AARCH64 prior art contradicts that proposal. IOW, prior art is inconsistent per se... I don't understand. Laszlo > On Mon, 11 Dec 2023, 15:00 Laszlo Ersek, > wrote: > > On 12/10/23 11:18, Mike Beaton wrote: > > From: Mike Beaton > > > > > This warning was already disabled in CLANGDWARF by commit > > d3225577123767fd09c91201d27e9c91663ae132. > > > > gcc can distinguish between optimised-away variable usage (as  can > occur in > > valid debug code) and genuinely unused variables, and only > complains about > > the latter. clang cannot, and therefore this warning ends up > complaining > > about valid debug code under clang. > > > > Since EDK-II code is in general going to be compiled by gcc as > well as clang > > then disabling this warning in clang does not amount to entirely > removing > > potentially valid warnings about genuinely unused variables. > > > > Signed-off-by: Mike Beaton > > > --- > >  BaseTools/Conf/tools_def.template | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/BaseTools/Conf/tools_def.template > b/BaseTools/Conf/tools_def.template > > index c34ecfd557..48cf45245f 100755 > > --- a/BaseTools/Conf/tools_def.template > > +++ b/BaseTools/Conf/tools_def.template > > @@ -1754,7 +1754,7 @@ DEFINE CLANGPDB_X64_PREFIX           = > ENV(CLANG_BIN) > >  DEFINE CLANGPDB_IA32_TARGET          = -target > i686-unknown-windows-gnu > >  DEFINE CLANGPDB_X64_TARGET           = -target > x86_64-unknown-windows-gnu > >  > > -DEFINE CLANGPDB_WARNING_OVERRIDES    = -Wno-parentheses-equality > -Wno-tautological-compare > -Wno-tautological-constant-out-of-range-compare -Wno-empty-body > -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option > -Wno-unused-but-set-variable -Wno-unused-const-variable > -Wno-unaligned-access -Wno-microsoft-enum-forward-reference > > +DEFINE CLANGPDB_WARNING_OVERRIDES    = -Wno-parentheses-equality > -Wno-tautological-compare > -Wno-tautological-constant-out-of-range-compare -Wno-empty-body > -Wno-unused-const-variable -Wno-varargs -Wno-unknown-warning-option > -Wno-unused-but-set-variable -Wno-unused-const-variable > -Wno-unaligned-access -Wno-unneeded-internal-declaration > -Wno-microsoft-enum-forward-reference > >  DEFINE CLANGPDB_ALL_CC_FLAGS         = DEF(GCC48_ALL_CC_FLAGS) > DEF(CLANGPDB_WARNING_OVERRIDES) -fno-stack-protector -funsigned-char > -ftrap-function=undefined_behavior_has_been_optimized_away_by_clang > -Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas > -Wno-incompatible-library-redeclaration -Wno-null-dereference > -mno-implicit-float -mms-bitfields -mno-stack-arg-probe -nostdlib > -nostdlibinc -fseh-exceptions > >  > >  ########################### > > AFAICT, CLANGPDB_WARNING_OVERRIDES gets included in > CLANGPDB_ALL_CC_FLAGS, which in turn gets included in all three of > DEBUG, RELEASE and NOOPT build target flags. > > The original report was "RELEASE CLANGPDB OVMF currently does not > compile". > > Can we use "-Wno-unneeded-internal-declaration" with RELEASE builds > only? > > Thanks, > Laszlo > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112316): https://edk2.groups.io/g/devel/message/112316 Mute This Topic: https://groups.io/mt/103087794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-