Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology

["Lendacky, Thomas via groups.io" <thomas.lendacky=amd.com@groups.io>]

On 1/25/24 04:20, Ni, Ray via groups.io wrote:
> Acked-by: Ray Ni <ray.ni@intel.com>
> 
> + Tom

Looks good to me. Should AmdGetProcessorLocation2ByApicId() be STATIC?

Not asking for this patch series, but there is a lot of duplicated code 
between the two APIC libraries. It would be nice if there was a way to 
have a common file where just a single copy of the duplicated code could live.

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

Thanks,
Tom

> 
> Thanks,
> Ray
>> -----Original Message-----
>> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
>> Sent: Thursday, January 25, 2024 1:02 PM
>> To: devel@edk2.groups.io
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni,
>> Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd
>> Hoffmann <kraxel@redhat.com>
>> Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended
>> topology
>>
>> Gentle reminder, please review the patch series.
>>
>> On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote:
>>> Caution: This message originated from an External Source. Use proper
>> caution when opening attachments, clicking links, or responding.
>>>
>>>
>>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>>
>>> Resending the patch with updated Cc list.
>>>
>>> PR: https://github.com/tianocore/edk2/pull/5269
>>>
>>> V2: delta changes
>>>    - Added additional check apart from supported CPUID extneded number.
>>>    - removed EFIAPI
>>>
>>> Implements AMD extended toplogy.
>>> Adds CPUID macro
>>> update APIC library to use new exteded cpuid.
>>>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>>> Cc: Ray Ni <ray.ni@intel.com>
>>> Cc: Rahul Kumar <rahul1.kumar@intel.com>
>>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>>>
>>> Abdul Lateef Attar (2):
>>>     MdePkg: Adds AMD Extended CPU topology CPUID
>>>     UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu
>> topology
>>>
>>>    MdePkg/Include/Register/Amd/Cpuid.h           |  23 +++-
>>>    .../Library/BaseXApicLib/BaseXApicLib.c       | 126
>> +++++++++++++++++-
>>>    .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c   | 126
>> +++++++++++++++++-
>>>    3 files changed, 272 insertions(+), 3 deletions(-)
>>>
>>> --
>>> 2.34.1
>>>
>>>
>>>
>>>
>>>
>>>
> 
> 
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114430): https://edk2.groups.io/g/devel/message/114430
Mute This Topic: https://groups.io/mt/103802341/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-