[edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview

[edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview

[Shenbagadevi R via groups.io]

Add changes to print PMIC and RCD details of Smbios Type17 in Shell
smbiosview command

Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c      | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 35369f0183..0fbaeb88ae 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -902,6 +902,13 @@ SmbiosPrintStructure (
         ShellPrintEx (-1, -1, L"Extended Speed: 0x%x\n", Struct->Type17->ExtendedSpeed);

         ShellPrintEx (-1, -1, L"Extended Configured Memory Speed: 0x%x\n", Struct->Type17->ExtendedConfiguredMemorySpeed);

       }

+

+      if (AE_SMBIOS_VERSION (0x3, 0x7) && (Struct->Hdr->Length > 0x5C)) {

+        ShellPrintEx (-1, -1, L"PMIC0 Manufacturer ID: 0x%x\n", Struct->Type17->Pmic0ManufacturerID);

+        ShellPrintEx (-1, -1, L"PMIC0 Revision Number: 0x%x\n", Struct->Type17->Pmic0RevisionNumber);

+        ShellPrintEx (-1, -1, L"RCD Manufacturer ID: 0x%x\n", Struct->Type17->RcdManufacturerID);

+        ShellPrintEx (-1, -1, L"RCD Revision Number: 0x%x\n", Struct->Type17->RcdRevisionNumber);

+      }



       break;



--
2.38.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118170): https://edk2.groups.io/g/devel/message/118170
Mute This Topic: https://groups.io/mt/105690959/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview

[Giri Mudusuru via groups.io]

[-- Attachment #1: Type: text/plain, Size: 3149 bytes --]

Reviewed-By: Giri Mudusuru <girimudusuru@microsoft.com>
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Shenbagadevi R via groups.io <shenbagadevir=ami.com@groups.io>
Sent: Tuesday, April 23, 2024 4:59 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Shenbagadevi R <shenbagadevir@ami.com>
Cc: gaoliming@byosoft.com.cn <gaoliming@byosoft.com.cn>; Sainadh Nagolu <sainadhn@ami.com>; Sundaresan S <sundaresans@ami.com>; Srinivasan Mani <srinivasanm@ami.com>; Ramesh R <rameshr@ami.com>; Karthika R <karthikar@ami.com>
Subject: [EXTERNAL] [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview

[You don't often get email from shenbagadevir=ami.com@groups.io. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

Add changes to print PMIC and RCD details of Smbios Type17 in Shell
smbiosview command

Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c      | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 35369f0183..0fbaeb88ae 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -902,6 +902,13 @@ SmbiosPrintStructure (
         ShellPrintEx (-1, -1, L"Extended Speed: 0x%x\n", Struct->Type17->ExtendedSpeed);

         ShellPrintEx (-1, -1, L"Extended Configured Memory Speed: 0x%x\n", Struct->Type17->ExtendedConfiguredMemorySpeed);

       }

+

+      if (AE_SMBIOS_VERSION (0x3, 0x7) && (Struct->Hdr->Length > 0x5C)) {

+        ShellPrintEx (-1, -1, L"PMIC0 Manufacturer ID: 0x%x\n", Struct->Type17->Pmic0ManufacturerID);

+        ShellPrintEx (-1, -1, L"PMIC0 Revision Number: 0x%x\n", Struct->Type17->Pmic0RevisionNumber);

+        ShellPrintEx (-1, -1, L"RCD Manufacturer ID: 0x%x\n", Struct->Type17->RcdManufacturerID);

+        ShellPrintEx (-1, -1, L"RCD Revision Number: 0x%x\n", Struct->Type17->RcdRevisionNumber);

+      }



       break;



--
2.38.0.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.







-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118245): https://edk2.groups.io/g/devel/message/118245
Mute This Topic: https://groups.io/mt/105690959/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5143 bytes --]

Re: [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview

[Sainadh Nagolu via groups.io]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Hi Giri/ Liming,

Please confirm if we can proceed to create Pull Request(PR) for these changes.

Thanks,
Sainadh.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118415): https://edk2.groups.io/g/devel/message/118415
Mute This Topic: https://groups.io/mt/105690959/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 919 bytes --]

回复: [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview

[gaoliming via groups.io]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Shenbagadevi
> R via groups.io
> 发送时间: 2024年4月23日 20:00
> 收件人: devel@edk2.groups.io; Shenbagadevi R <shenbagadevir@ami.com>
> 抄送: gaoliming@byosoft.com.cn; Sainadh Nagolu <sainadhn@ami.com>;
> Sundaresan S <sundaresans@ami.com>; Srinivasan Mani
> <srinivasanm@ami.com>; Ramesh R <rameshr@ami.com>; Karthika R
> <karthikar@ami.com>
> 主题: [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell
> Smbiosview
> 
> Add changes to print PMIC and RCD details of Smbios Type17 in Shell
> smbiosview command
> 
> Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c      | 7
> +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 35369f0183..0fbaeb88ae 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -902,6 +902,13 @@ SmbiosPrintStructure (
>          ShellPrintEx (-1, -1, L"Extended Speed: 0x%x\n",
> Struct->Type17->ExtendedSpeed);
> 
>          ShellPrintEx (-1, -1, L"Extended Configured Memory Speed:
> 0x%x\n", Struct->Type17->ExtendedConfiguredMemorySpeed);
> 
>        }
> 
> +
> 
> +      if (AE_SMBIOS_VERSION (0x3, 0x7) && (Struct->Hdr->Length > 0x5C))
> {
> 
> +        ShellPrintEx (-1, -1, L"PMIC0 Manufacturer ID: 0x%x\n",
> Struct->Type17->Pmic0ManufacturerID);
> 
> +        ShellPrintEx (-1, -1, L"PMIC0 Revision Number: 0x%x\n",
> Struct->Type17->Pmic0RevisionNumber);
> 
> +        ShellPrintEx (-1, -1, L"RCD Manufacturer ID: 0x%x\n",
> Struct->Type17->RcdManufacturerID);
> 
> +        ShellPrintEx (-1, -1, L"RCD Revision Number: 0x%x\n",
> Struct->Type17->RcdRevisionNumber);
> 
> +      }
> 
> 
> 
>        break;
> 
> 
> 
> --
> 2.38.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118417): https://edk2.groups.io/g/devel/message/118417
Mute This Topic: https://groups.io/mt/105816495/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-