From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 23 Sep 2019 02:56:44 -0700 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 421FE3A206 for ; Mon, 23 Sep 2019 09:56:44 +0000 (UTC) Received: by mail-wr1-f72.google.com with SMTP id n18so4621699wro.11 for ; Mon, 23 Sep 2019 02:56:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7Q1UEe5uz/90bQuToEM+NGbz3TxT3JbntRVZmx+tKF4=; b=ZWTd2+ppJzj5rZvvTmVT8YQN1gDNtxxhCqpoDrYNDGiVMvI5R8KuAFyG+rnu6EGUWp HSvtWk1JeVzi8g/c6/wlaC0iEU2OggjFUf11RwLgFsilvqJg7ga+nBxBcNZEwCR/BgFc 5trQyErlImvWJIJuM+HM28r6G+3S6HvxZtxtmJrQV4gNPhDp+nxyJzC3f3Ob2kYuves3 RumunEh8GmOaWeEG7BAxcvYROyG8A86x51nrOocQ+3P2X0/SNpdIPhBtNNgwjwrOCPUz zXTzIwSLjfXg816RzL7sPpBSRaFRWJ91RPGxfj0z61Pcj0lqDNofXsmqogDJagXb3V2f QtUQ== X-Gm-Message-State: APjAAAVegzCJj999Btt/lsJfgH5DvoBtNHR1cpG5wkaJ2oi9cr+DMt4G kYACxgUh4jI+uurWJvsqL4G3LfSLpQzNTwowHy/fgORsaQmZiNluz4p44zDoPzHcaHWPWoYnMci 8zg7xW/8ESdmDSw== X-Received: by 2002:adf:e392:: with SMTP id e18mr21159268wrm.87.1569232603075; Mon, 23 Sep 2019 02:56:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxOP+FDvCVQLOQfUnH4ZBiG8uY9v2WpaYGATuVhy1eXK6kIkWfoAiY7Ix8JJSt41s6WFWzug== X-Received: by 2002:adf:e392:: with SMTP id e18mr21159252wrm.87.1569232602866; Mon, 23 Sep 2019 02:56:42 -0700 (PDT) Received: from [192.168.1.40] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id r9sm15017790wra.19.2019.09.23.02.56.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 02:56:42 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration To: devel@edk2.groups.io, lersek@redhat.com Cc: Chao Zhang , Jian Wang , Jiewen Yao References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-28-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <1247d9da-fa09-9bc8-797a-e55be28c1081@redhat.com> Date: Mon, 23 Sep 2019 11:56:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-28-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 9/17/19 9:49 PM, Laszlo Ersek wrote: > EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", > similarly to gBS->RegisterProtocolNotify(). We should pass the address of > an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT > just happens to be specified as (VOID*), and has nothing to do with the > registration. > > This change is a no-op in practice; it's a semantic improvement. > > Cc: Chao Zhang > Cc: Jian Wang > Cc: Jiewen Yao > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > SecurityPkg/HddPassword/HddPasswordDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.c b/SecurityPkg/HddPassword/HddPasswordDxe.c > index b0d795b6597f..051e64091d7f 100644 > --- a/SecurityPkg/HddPassword/HddPasswordDxe.c > +++ b/SecurityPkg/HddPassword/HddPasswordDxe.c > @@ -2770,7 +2770,7 @@ HddPasswordDxeInit ( > { > EFI_STATUS Status; > HDD_PASSWORD_DXE_PRIVATE_DATA *Private; > - EFI_EVENT Registration; > + VOID *Registration; > EFI_EVENT EndOfDxeEvent; > EDKII_VARIABLE_LOCK_PROTOCOL *VariableLock; > > Reviewed-by: Philippe Mathieu-Daude