From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A06B3D81113 for ; Tue, 16 Jan 2024 12:12:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/VoMpO//lcwxWy0F3mrOZj/BufgE/+xdvUdYTECBmtk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1705407171; v=1; b=tknx7CX+hya0S4NUIi/JGfCHF5u9BNpP0/k8ltTHe2laX5CvFmVIUfQX6xpnKk6Kw7tAa5YO G6VcooZCWpNoWappghXtTffLWtjK7rmXaisgX6+YzD+2QRNsiAu/UL/+GCf2BuwAsZNsc442Qu+ ZaDCcJhkKer5LcQppttKgzCQ= X-Received: by 127.0.0.2 with SMTP id vXBVYY7687511xyc2UuJxMrD; Tue, 16 Jan 2024 04:12:51 -0800 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.12005.1705407169752607084 for ; Tue, 16 Jan 2024 04:12:50 -0800 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8BxXeu+cqZln7EAAA--.3216S3; Tue, 16 Jan 2024 20:12:46 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxDc+9cqZlvwIEAA--.20945S3; Tue, 16 Jan 2024 20:12:45 +0800 (CST) Message-ID: <124d7ef9-47ea-4753-a9aa-6d2ea6a84a8e@loongson.cn> Date: Tue, 16 Jan 2024 20:12:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch To: devel@edk2.groups.io, qiandongyan@loongson.cn Cc: Zhichao Gao References: <20240116071133.38331-1-qiandongyan@loongson.cn> <20240116071133.38331-2-qiandongyan@loongson.cn> From: "Chao Li" In-Reply-To: <20240116071133.38331-2-qiandongyan@loongson.cn> X-CM-TRANSID: AQAAf8DxDc+9cqZlvwIEAA--.20945S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQASCGWmPl8EEAAJsk X-Coremail-Antispam: 1Uk129KBj93XoWxGF17XrWDGr1DZw1kXw18JFc_yoW5Xw4Upw 1UAw47GF4UZ34jkw13Ga1kXF15t3sxGr4DX393tayUurZrG3Wvg34jvFnrtay5CFW3Gw1S gr9Ig3yvgF1DJrXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUyKb4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jrv_JF 1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73Uj IFyTuYvjxUw6pBDUUUU Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: M88ITivSykBGKhvxQuhQzOazx7686176AA= Content-Type: multipart/alternative; boundary="------------Z04w82NhlV6RAQnw6mRk56OJ" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tknx7CX+; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------Z04w82NhlV6RAQnw6mRk56OJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Chao Li Hi Zhichao, Please help review this patch. Thanks, Chao On 2024/1/16 15:11, Dongyan Qian wrote: > According to SMBIOS spec3.6, LoongArch information support has been added= , > so this patch is submitted for display as information in smbiosview. > > Cc: Zhichao Gao > Cc: Chao Li > Signed-off-by: Dongyan Qian > --- > .../SmbiosView/PrintInfo.c | 68 +++++++++++++++++++ > .../SmbiosView/QueryTable.c | 8 +++ > 2 files changed, 76 insertions(+) > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/Print= Info.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index b6968cb36a..ba6e7b15fc 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 ( > Print (L"RISC-V RV128\n"); > break; > =20 > + case 0x258: > + Print (L"LoongArch\n"); > + break; > + > + case 0x259: > + Print (L"Loongson1\n"); > + break; > + > + case 0x25a: > + Print (L"Loongson2\n"); > + break; > + > + case 0x25b: > + Print (L"Loongson3\n"); > + break; > + > + case 0x25c: > + Print (L"Loongson2K\n"); > + break; > + > + case 0x25d: > + Print (L"Loongson3A\n"); > + break; > + > + case 0x25e: > + Print (L"Loongson3B\n"); > + break; > + > + case 0x25f: > + Print (L"Loongson3C\n"); > + break; > + > + case 0x260: > + Print (L"Loongson3D\n"); > + break; > + > + case 0x261: > + Print (L"Loongson3E\n"); > + break; > + > + case 0x262: > + Print (L"DualCoreLoongson2K\n"); > + break; > + > + case 0x26C: > + Print (L"QuadCoreLoongson3A\n"); > + break; > + > + case 0x26D: > + Print (L"MultiCoreLoongson3A\n"); > + break; > + > + case 0x26E: > + Print (L"QuadCoreLoongson3B\n"); > + break; > + > + case 0x26F: > + Print (L"MultiCoreLoongson3B\n"); > + break; > + > + case 0x270: > + Print (L"MultiCoreLoongson3C\n"); > + break; > + > + case 0x271: > + Print (L"MultiCoreLoongson3D\n"); > + break; > + > default: > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINT= INFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle); > } > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/Query= Table.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable= .c > index 82bb7a41f0..f57093c91c 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > @@ -3652,6 +3652,14 @@ TABLE_ITEM ProcessorArchitectureTypesTable[] =3D = { > { > 8, > L" 128-bit RISC-V (RV128) " > + }, > + { > + 9, > + L" 32-bit LoongArch (LoongArch32) " > + }, > + { > + 10, > + L" 64-bit LoongArch (LoongArch64) " > } > }; > =20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113891): https://edk2.groups.io/g/devel/message/113891 Mute This Topic: https://groups.io/mt/103757733/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------Z04w82NhlV6RAQnw6mRk56OJ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Hi Zhichao,

Please help review this patch.


=
Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:<= br> 
According to SMBIOS spec3.6, L=
oongArch information support has been added,
so this patch is submitted for display as information in smbiosview.

Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 .../SmbiosView/PrintInfo.c                    | 68 +++++++++++++++++++
 .../SmbiosView/QueryTable.c                   |  8 +++
 2 files changed, 76 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintIn=
fo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index b6968cb36a..ba6e7b15fc 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 (
       Print (L"RISC-V RV128\n");
       break;
=20
+    case 0x258:
+      Print (L"LoongArch\n");
+      break;
+
+    case 0x259:
+      Print (L"Loongson1\n");
+      break;
+
+    case 0x25a:
+      Print (L"Loongson2\n");
+      break;
+
+    case 0x25b:
+      Print (L"Loongson3\n");
+      break;
+
+    case 0x25c:
+      Print (L"Loongson2K\n");
+      break;
+
+    case 0x25d:
+      Print (L"Loongson3A\n");
+      break;
+
+    case 0x25e:
+      Print (L"Loongson3B\n");
+      break;
+
+    case 0x25f:
+      Print (L"Loongson3C\n");
+      break;
+
+    case 0x260:
+      Print (L"Loongson3D\n");
+      break;
+
+    case 0x261:
+      Print (L"Loongson3E\n");
+      break;
+
+    case 0x262:
+      Print (L"DualCoreLoongson2K\n");
+      break;
+
+    case 0x26C:
+      Print (L"QuadCoreLoongson3A\n");
+      break;
+
+    case 0x26D:
+      Print (L"MultiCoreLoongson3A\n");
+      break;
+
+    case 0x26E:
+      Print (L"QuadCoreLoongson3B\n");
+      break;
+
+    case 0x26F:
+      Print (L"MultiCoreLoongson3B\n");
+      break;
+
+    case 0x270:
+      Print (L"MultiCoreLoongson3C\n");
+      break;
+
+    case 0x271:
+      Print (L"MultiCoreLoongson3D\n");
+      break;
+
     default:
       ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINF=
O_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);
   }
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTa=
ble.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 82bb7a41f0..f57093c91c 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -3652,6 +3652,14 @@ TABLE_ITEM  ProcessorArchitectureTypesTable[] =3D {
   {
     8,
     L" 128-bit RISC-V (RV128) "
+  },
+  {
+    9,
+    L" 32-bit LoongArch (LoongArch32) "
+  },
+  {
+    10,
+    L" 64-bit LoongArch (LoongArch64) "
   }
 };
=20
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#113891) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------Z04w82NhlV6RAQnw6mRk56OJ--