From: "levi.yun" <yeoreum.yun@arm.com>
To: "Adam Liu" <adam.liu@tw.synaptics.com>, devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error
Date: Mon, 18 Mar 2024 03:40:12 -0700 [thread overview]
Message-ID: <12640.1710758412095001607@groups.io> (raw)
In-Reply-To: <20240318034544.589397-2-adam.liu@tw.synaptics.com>
[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]
I think it would be nice if you add
diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
index 3e58119b25d2..505d3765c522 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
@@ -9,6 +9,7 @@
GCC_ASM_EXPORT(SetJump)
GCC_ASM_EXPORT(InternalLongJump)
+GCC_ASM_IMPORT(InternalAssertJumpBuffer)
#define GPR_LAYOUT \
REG_PAIR (x19, x20, 0); \
Thou, the gcc doesn't raise compile error
(in ASM_FLAG, there's no option set "-Werror-implicit-function-declaration")
Otherwise,
Reviewed-by: levi.yun <yeoreum.yun@arm.com>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116837): https://edk2.groups.io/g/devel/message/116837
Mute This Topic: https://groups.io/mt/104997022/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 1816 bytes --]
prev parent reply other threads:[~2024-03-18 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 3:45 [edk2-devel] [PATCH v1 0/1] MdePkg/BaseLib: Fix AARCH64 compilation error Adam Liu
2024-03-18 3:45 ` [edk2-devel] [PATCH v1 1/1] " Adam Liu
2024-03-18 10:40 ` levi.yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12640.1710758412095001607@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox