From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2A8D794136C for ; Mon, 18 Mar 2024 10:40:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=E4AGuIzDCyb0ciC6QTwcJaa1uZKHz4v9qwHcquskhXU=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710758412; v=1; b=XYqGQCuqcbVDhBbbE/+ljgIOxDo8jZXZEyRJq1sl6wbuxzQoluVIZoHowJLrGbZ/3HboM7BT hHzt2tTe7xoEnh262Vy8PERZde4Nan0mR9Ji4tKOTlbCRhV5GMRlGsDi78cLSTyT2vwk66jmMrE stZ6yKvwiJpDrsYGcMlpJkUS1tBYjsZ+SH4EkR1lgrJsPabr1Cip1qcQOG5/b9Xbt+eKA40SflM M0wljXNsvrU6YNUFuP6LdCGA7+yFextDhrKg4A0Mn9J12fas79i5ft2tVlUmS7uHDrb038r4oMn Gt1CV6ikoP+g7lVcjY3+pu598pWUTbEYyYX+VcKDUqFJQ== X-Received: by 127.0.0.2 with SMTP id i1PvYY7687511x9aMpSXkZeO; Mon, 18 Mar 2024 03:40:12 -0700 Subject: Re: [edk2-devel] [PATCH v1 1/1] MdePkg/BaseLib: Fix AARCH64 compilation error To: "Adam Liu" , devel@edk2.groups.io From: "levi.yun" X-Originating-Location: Cambridge, England, GB (217.140.99.251) X-Originating-Platform: Mac Chrome 122 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Mon, 18 Mar 2024 03:40:12 -0700 References: <20240318034544.589397-2-adam.liu@tw.synaptics.com> In-Reply-To: <20240318034544.589397-2-adam.liu@tw.synaptics.com> Message-ID: <12640.1710758412095001607@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: xEma0RPpTNQJXKfPvSF6454Dx7686176AA= Content-Type: multipart/alternative; boundary="Iu5g3pd1WYxi4GQ5f0SL" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=XYqGQCuq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --Iu5g3pd1WYxi4GQ5f0SL Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I think it would be nice if you add diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg/Libr= ary/BaseLib/AArch64/SetJumpLongJump.S index 3e58119b25d2..505d3765c522 100644 --- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S +++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S @@ -9,6 +9,7 @@ GCC_ASM_EXPORT(SetJump) GCC_ASM_EXPORT(InternalLongJump) +GCC_ASM_IMPORT(InternalAssertJumpBuffer) #define GPR_LAYOUT=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\ REG_PAIR (x19, x20,=C2=A0 0);=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\ Thou, the gcc doesn't raise compile error (in ASM_FLAG, there's no option set "-Werror-implicit-function-declaration"= ) Otherwise, Reviewed-by: levi.yun -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116837): https://edk2.groups.io/g/devel/message/116837 Mute This Topic: https://groups.io/mt/104997022/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --Iu5g3pd1WYxi4GQ5f0SL Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable I think it would be nice if you add

diff --git a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S b/MdePkg= /Library/BaseLib/AArch64/SetJumpLongJump.S
index 3e58119b25d2..505d3765c522 100644
--- a/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
+++ b/MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S
@@ -9,6 +9,7 @@
 
 GCC_ASM_EXPORT(SetJump)
 GCC_ASM_EXPORT(InternalLongJump)
+GCC_ASM_IMPORT(InternalAssertJumpBuffer)
 
 #define GPR_LAYOUT            &nbs= p;            \
         REG_PAIR (x19, x20,  0);  =          \

Thou, the gcc doesn't raise = compile error
(in ASM_FLAG, there's no option set "-Werror-implicit-f= unction-declaration")

Otherwise,

Reviewed-by: levi.yu= n <yeoreum.yun@arm.com>
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116837) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--Iu5g3pd1WYxi4GQ5f0SL--