From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: jiewen.yao@intel.com, thomas.abraham@arm.com,
Sughosh.Ganu@arm.com, Matteo.Carlini@arm.com,
Ben.Adderson@arm.com, nd@arm.com
Subject: Re: [PATCH v3 00/26] Enable Core CI support for StandaloneMmPkg
Date: Wed, 6 Jan 2021 14:58:48 +0100 [thread overview]
Message-ID: <1270155f-f638-42a1-7056-287b5bf7288c@arm.com> (raw)
In-Reply-To: <20210104132213.22376-1-sami.mujawar@arm.com>
On 1/4/21 2:21 PM, Sami Mujawar wrote:
> Bugzilla: 3150 (https://bugzilla.tianocore.org/show_bug.cgi?id=3150)
>
> The EDKII Core CI runs the ECC tool that checks for good coding
> practices and the coding standard. This patch series fixes the
> ECC errors reported in the StandaloneMmPkg and enables support
> for EDKII Core CI.
>
> This v3 series:
> - PATCH 26: Updated readme.md file to add check mark to the
> windows column.
> - Added bugzilla ID to the commit messages for the patches in
> the series.
> Ref: https://edk2.groups.io/g/devel/topic/edk2_devel_patch/79194663
> - There is no code change for Patches 1 to 25 since the v2 series.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/1516_standalonemmpkg_ci_v3
>
> Sami Mujawar (26):
> StandaloneMmPkg: Add library header files to DEC
> StandaloneMmPkg: Add library files to DSC
> StandaloneMmPkg: Fix spell check reported errors
> StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher
> StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management
> StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 4002 in FwVol helper
> StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore
> StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore
> StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib
> StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 9003 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 9001 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core
> StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib
> StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu
> StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint
> StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec
> StandaloneMmPkg: Add EDK2 Core CI support
> .azurepipelines: Add StandaloneMmPkg to CI matrix
> .pytool: CI Settings to support StandaloneMmPkg
>
This all looks fine to me.
Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
but you might want to update the copyright years to 2021 instead of 2020
before pushing.
> .azurepipelines/templates/pr-gate-build-job.yml | 2 +-
> .pytool/CISettings.py | 1 +
> .pytool/Readme.md | 2 +-
> StandaloneMmPkg/Core/Dependency.c | 6 +-
> StandaloneMmPkg/Core/Dispatcher.c | 49 ++++++------
> StandaloneMmPkg/Core/FwVol.c | 36 +++++----
> StandaloneMmPkg/Core/Locate.c | 6 +-
> StandaloneMmPkg/Core/Mmi.c | 4 +-
> StandaloneMmPkg/Core/Pool.c | 6 +-
> StandaloneMmPkg/Core/StandaloneMmCore.c | 37 ++++++---
> StandaloneMmPkg/Core/StandaloneMmCore.h | 12 +--
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/EventHandle.c | 56 ++++++++++---
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.c | 34 ++++++--
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.h | 31 +++++++-
> StandaloneMmPkg/Drivers/StandaloneMmCpu/AArch64/StandaloneMmCpu.inf | 9 +--
> StandaloneMmPkg/Include/Guid/MmCoreData.h | 6 +-
> StandaloneMmPkg/Include/Library/AArch64/StandaloneMmCoreEntryPoint.h | 47 ++++++-----
> StandaloneMmPkg/Include/Library/StandaloneMmDriverEntryPoint.h | 4 +-
> StandaloneMmPkg/Include/Library/StandaloneMmMemLib.h | 6 +-
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/CreateHobList.c | 6 +-
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/SetPermissions.c | 53 +++++++++++-
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 32 +++++---
> StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/StandaloneMmCoreEntryPoint.inf | 3 +-
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.c | 6 +-
> StandaloneMmPkg/Library/StandaloneMmCoreMemoryAllocationLib/StandaloneMmCoreMemoryAllocationLib.inf | 4 +-
> StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c | 10 +--
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.c | 4 +-
> StandaloneMmPkg/Library/VariableMmDependency/VariableMmDependency.inf | 4 +-
> StandaloneMmPkg/StandaloneMmPkg.ci.yaml | 84 ++++++++++++++++++++
> StandaloneMmPkg/StandaloneMmPkg.dec | 20 ++++-
> StandaloneMmPkg/StandaloneMmPkg.dsc | 15 +++-
> 31 files changed, 439 insertions(+), 156 deletions(-)
> create mode 100644 StandaloneMmPkg/StandaloneMmPkg.ci.yaml
>
prev parent reply other threads:[~2021-01-06 13:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 13:21 [PATCH v3 00/26] Enable Core CI support for StandaloneMmPkg Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 01/26] StandaloneMmPkg: Add library header files to DEC Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 02/26] StandaloneMmPkg: Add library files to DSC Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 03/26] StandaloneMmPkg: Fix spell check reported errors Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 04/26] StandaloneMmPkg: Fix ECC error 9002 in Core dispatcher Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 05/26] StandaloneMmPkg: Fix ECC error 1001 in SMM Memory pool management Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 06/26] StandaloneMmPkg: Fix ECC error 3002 in StandaloneMmCpu Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 07/26] StandaloneMmPkg: Fix ECC error 4002 in FwVol helper Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 08/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCoreEntryPoint Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 09/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCpu Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 10/26] StandaloneMmPkg: Fix ECC error 5007 in StandaloneMmCore Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 11/26] StandaloneMmPkg: Fix ECC error 10014 in StandaloneMmCpu Sami Mujawar
2021-01-04 13:21 ` [PATCH v3 12/26] StandaloneMmPkg: Fix ECC error 4002 and 9002 in StandaloneMmCore Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 13/26] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCoreEntryPoint Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 14/26] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmMemLib Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 15/26] StandaloneMmPkg: Fix ECC error 9002 in StandaloneMmCoreEntryPoint Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 16/26] StandaloneMmPkg: Fix ECC error 9003 " Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 17/26] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 18/26] StandaloneMmPkg: Fix ECC error 9001 " Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 19/26] StandaloneMmPkg: Fix ECC error 9001 in Standalone MM Core Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 20/26] StandaloneMmPkg: Fix ECC error 9002 in CoreMemoryAllocationLib Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 21/26] StandaloneMmPkg: Fix ECC error 4002 in StandaloneMmCpu Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 22/26] StandaloneMmPkg: Fix ECC error 8005 in StandaloneMmCoreEntryPoint Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 23/26] StandaloneMmPkg: Remove dependency on ArmPlatformPkg.dec Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 24/26] StandaloneMmPkg: Add EDK2 Core CI support Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 25/26] .azurepipelines: Add StandaloneMmPkg to CI matrix Sami Mujawar
2021-01-06 16:48 ` Sami Mujawar
2021-01-04 13:22 ` [PATCH v3 26/26] .pytool: CI Settings to support StandaloneMmPkg Sami Mujawar
[not found] ` <16570A30CC60F0BE.14857@groups.io>
2021-01-04 13:43 ` [edk2-devel] " Sami Mujawar
2021-01-07 1:27 ` 回复: " gaoliming
2021-01-06 16:49 ` Sami Mujawar
2021-01-06 13:58 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270155f-f638-42a1-7056-287b5bf7288c@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox