From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v2 05/15] ArmPkg: Document libraries in ArmPkg.dec
To: PierreGondois <pierre.gondois@arm.com>,devel@edk2.groups.io
From: "Sami Mujawar" <sami.mujawar@arm.com>
X-Originating-Location: GB (217.140.99.251)
X-Originating-Platform: Mac Firefox 88
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Tue, 27 Apr 2021 10:41:55 -0700
References: <20210427153251.11576-6-Pierre.Gondois@arm.com>
In-Reply-To: <20210427153251.11576-6-Pierre.Gondois@arm.com>
Message-ID: <12737.1619545315284790387@groups.io>
Content-Type: multipart/alternative; boundary="Z9aqvNAZk4ZbSAZXGMNI"

--Z9aqvNAZk4ZbSAZXGMNI
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Pierre,

On Tue, Apr 27, 2021 at 08:33 AM, PierreGondois wrote:

>=20
> +
> + ## @libraryclass Provides an interface to initialize a
> + # Generic Interrupt Controller (GIC).
> + #
> SemihostLib|Include/Library/SemihostLib.h
> +
> + ## @libraryclass Provides a Generic Interrupt Controller (GIC)
> + # configuration interface.
> + #
> DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h

The help text seems to mismatch for the libraries above. However, this see=
ms to be correct in the patch that Re-orders the libraries alphabetically.
Can you update this patch, please?

With that changed.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

--Z9aqvNAZk4ZbSAZXGMNI
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Pierre,<br /><br />On Tue, Apr 27, 2021 at 08:33 AM, PierreGondois wrote=
:<br />
<blockquote>+<br />+ ## @libraryclass Provides an interface to initialize =
a<br />+ # Generic Interrupt Controller (GIC).<br />+ #<br />SemihostLib|In=
clude/Library/SemihostLib.h<br />+<br />+ ## @libraryclass Provides a Gener=
ic Interrupt Controller (GIC)<br />+ # configuration interface.<br />+ #<br=
 />DefaultExceptionHandlerLib|Include/Library/DefaultExceptionHandlerLib.h<=
/blockquote>
The help text seems to mismatch for the libraries above. However, this see=
ms to be correct in the patch that Re-orders the libraries alphabetically.<=
br />Can you update this patch, please?<br /><br />With that changed.<br />=
<br />Reviewed-by: Sami Mujawar &lt;sami.mujawar@arm.com&gt;<br /><br />Reg=
ards,<br /><br />Sami Mujawar

--Z9aqvNAZk4ZbSAZXGMNI--