Re: [edk2-devel] [PATCH] EmulatorPkg: Add the second console to Emulator

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Sorry, I didn't notice that.
I will fix that and send a new version.

Best Regards,
Zhiguang Liu


>-----Original Message-----
>From: Justen, Jordan L
>Sent: Monday, April 29, 2019 12:54 PM
>To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
>Cc: Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
>Subject: Re: [edk2-devel] [PATCH] EmulatorPkg: Add the second console to
>Emulator
>
>What do you think about this change to the commit message?
>
>EmulatorPkg: Support a second GOP window
>
>Two GOP screens will be created if PcdEmuGop is set in
>EmulatorPkg.dsc:
>
>gEmulatorPkgTokenSpaceGuid.PcdEmuGop|L"GOP Window 1!GOP Window
>2"
>
>On 2019-04-28 20:04:25, Zhiguang Liu wrote:
>> @@ -51,6 +83,10 @@ BDS_CONSOLE_CONNECT_ENTRY   gPlatformConsole[]
>= {
>>      (CONSOLE_OUT | CONSOLE_IN)
>>    },
>>    {
>> +(EFI_DEVICE_PATH_PROTOCOL *) &gGopDevicePath2,
>> +    (CONSOLE_OUT | CONSOLE_IN)
>> +  },
>> +    {
>
>The indentation looks wrong on these lines.
>
>With these fixes:
>Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
>
>>      NULL,
>>      0
>>    }