From: "Zhiguang Liu" <zhiguang.liu@intel.com>
To: "Justen, Jordan L" <jordan.l.justen@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Andrew Fish <afish@apple.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch V3] EmulatorPkg: don't display the cpu current speed
Date: Fri, 14 Jun 2019 00:28:22 +0000 [thread overview]
Message-ID: <12C615F56EBD0740AAC515819FA4CD356C46C2@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <156041202486.1843.6030893249902368241@jljusten-skl>
Thanks for the reply.
I understand now that this is not a very proper change.
I will talk to the bug reporter in Bugzilla to see if we can keep the current status.
Best Regards,
Zhiguang Liu
>-----Original Message-----
>From: Justen, Jordan L
>Sent: Thursday, June 13, 2019 3:47 PM
>To: Liu, Zhiguang <zhiguang.liu@intel.com>; devel@edk2.groups.io
>Cc: Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>
>Subject: RE: [Patch V3] EmulatorPkg: don't display the cpu current speed
>
>On 2019-06-11 22:42:13, Liu, Zhiguang wrote:
>> Thanks for the comments.
>> I will change the commit message in the next version.
>> But I don't think this is a issue worth making a major change.
>> Given that the change is consistent with NT32, will you agree with this
>change?
>
>Hmm. You are right that NT32 also does this. I don't agree enough to give you
>a Reviewed-by, but if Andrew or Ray give a Reviewed-by, then I'm ok for us to
>take the patch.
>
>-Jordan
prev parent reply other threads:[~2019-06-14 0:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 7:32 [Patch V3] EmulatorPkg: don't display the cpu current speed Zhiguang Liu
2019-06-11 7:55 ` Jordan Justen
2019-06-12 5:42 ` Zhiguang Liu
2019-06-13 7:47 ` Jordan Justen
2019-06-14 0:28 ` Zhiguang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12C615F56EBD0740AAC515819FA4CD356C46C2@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox