Re: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore

["Zhiguang Liu" <zhiguang.liu@intel.com>]

Thanks all for the comments. 
I agree that it will be more clear to split the patch. 
So, I will send a new version later.

Zhiguang

> -----Original Message-----
> From: Leif Lindholm <leif.lindholm@linaro.org>
> Sent: Friday, November 22, 2019 7:34 PM
> To: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: devel@edk2.groups.io; Liu, Zhiguang <zhiguang.liu@intel.com>; Gao,
> Liming <liming.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu,
> Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [Patch V2] MdeModulePkg:
> LzmaCustomDecompressLib.inf don't support EBC anymore
> 
> On Fri, Nov 22, 2019 at 12:30:13 +0100, Philippe Mathieu-Daudé wrote:
> > Hi,
> >
> > On 11/22/19 9:07 AM, Zhiguang Liu wrote:
> > > V1:
> > >
> > > After unifying the definition of size_t, EBC compiler has failure.
> > > So don't compile this inf file for EBC
> > >
> > > V2:
> > >
> > > Thanks for Leif's comment
> > > Updated VALID_ARCHITECTURES in inf file
> > >
> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
> > >
> > > Cc: Liming Gao <liming.gao@intel.com>
> > > Cc: Jian J Wang <jian.j.wang@intel.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > Reviewed-by: Liming Gao <liming.gao@intel.com>
> > >
> > > Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> > > ---
> > >
> MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
> essLib.inf | 2 +-
> > >   MdeModulePkg/MdeModulePkg.dsc                                            | 2 +-
> > >   2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > >
> a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom
> pressL
> > > ib.inf
> > >
> b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom
> pressL
> > > ib.inf
> > > index 42b741c64b..4ed1d83a40 100644
> > > ---
> > >
> a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom
> pressL
> > > ib.inf
> > > +++
> b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom
> pr
> > > +++ essLib.inf
> > > @@ -25,7 +25,7 @@
> > >   #
> > >   # The following information is for reference only and not required by the
> build tools.
> > >   #
> > > -#  VALID_ARCHITECTURES           = IA32 X64 EBC
> > > +#  VALID_ARCHITECTURES           = IA32 X64 AARCH64 ARM
> >
> > It looks you are doing 2 changes at once:
> > - Add ARM/Aarch64 which were missing to VALID_ARCHITECTURES
> > - Remove EBC (BZ#2338)
> 
> No. ARM/AARCH64 were already supported - but the comment had not
> been updated. So I suggested that when the comment was updated, it was
> updated to reflect actual reality rather than just drop the EBC.
> 
> (This would of course have been more clear in the diffs if the SetupGit.py
> script had been executed in the contributor's check-out, making the diff
> show the sections being modified.)
> 
> /
>     Leif
> 
> > Do you mind splitting this patch in 2 logical ones?
> > (Maybe it is cleaner to first fix BZ#2338, then add the missing archs.
> >
> > >   #
> > >   [Sources]
> > > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > > b/MdeModulePkg/MdeModulePkg.dsc index 4320839abf..f7dbb27ce2
> 100644
> > > --- a/MdeModulePkg/MdeModulePkg.dsc
> > > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > > @@ -299,7 +299,6 @@
> > >
> MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
> > >
> MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerL
> ibNull.inf
> > >
> > >
> MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSer
> > > ialPortPpi.inf
> > > -
> MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
> essLib.inf
> > >
> MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLib
> ReportStatusCode.inf
> > >
> MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
> > >     MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > @@ -433,6 +432,7 @@
> > >   [Components.IA32, Components.X64, Components.ARM,
> Components.AARCH64]
> > >
> > >
> MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompr
> es
> > > sLib.inf
> > > +
> > > +
> MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
> essL
> > > + ib.inf
> > >     MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> > >     MdeModulePkg/Core/Dxe/DxeMain.inf {
> > >       <LibraryClasses>
> > >
> >