From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.4671.1574645351772459916 for ; Sun, 24 Nov 2019 17:29:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhiguang.liu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Nov 2019 17:29:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,239,1571727600"; d="scan'208";a="233248616" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 24 Nov 2019 17:29:11 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 24 Nov 2019 17:29:10 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 24 Nov 2019 17:29:10 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.108]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 09:29:08 +0800 From: "Zhiguang Liu" To: Leif Lindholm , =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= CC: "devel@edk2.groups.io" , "Gao, Liming" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Thread-Topic: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Thread-Index: AQHVoSg0MJoJI7jTKU2JImJwL4IB+6eWiQ6AgASFvYA= Date: Mon, 25 Nov 2019 01:29:08 +0000 Message-ID: <12C615F56EBD0740AAC515819FA4CD35731A5D@shsmsx102.ccr.corp.intel.com> References: <20191122080726.36584-1-zhiguang.liu@intel.com> <20191122113403.GB7359@bivouac.eciton.net> In-Reply-To: <20191122113403.GB7359@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhiguang.liu@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Thanks all for the comments.=20 I agree that it will be more clear to split the patch.=20 So, I will send a new version later. Zhiguang > -----Original Message----- > From: Leif Lindholm > Sent: Friday, November 22, 2019 7:34 PM > To: Philippe Mathieu-Daud=E9 > Cc: devel@edk2.groups.io; Liu, Zhiguang ; Gao, > Liming ; Wang, Jian J ; Wu, > Hao A > Subject: Re: [edk2-devel] [Patch V2] MdeModulePkg: > LzmaCustomDecompressLib.inf don't support EBC anymore >=20 > On Fri, Nov 22, 2019 at 12:30:13 +0100, Philippe Mathieu-Daud=E9 wrote: > > Hi, > > > > On 11/22/19 9:07 AM, Zhiguang Liu wrote: > > > V1: > > > > > > After unifying the definition of size_t, EBC compiler has failure. > > > So don't compile this inf file for EBC > > > > > > V2: > > > > > > Thanks for Leif's comment > > > Updated VALID_ARCHITECTURES in inf file > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2338 > > > > > > Cc: Liming Gao > > > Cc: Jian J Wang > > > Cc: Hao A Wu > > > Cc: Leif Lindholm > > > Reviewed-by: Liming Gao > > > > > > Signed-off-by: Zhiguang Liu > > > --- > > > > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr > essLib.inf | 2 +- > > > MdeModulePkg/MdeModulePkg.dsc = | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git > > > > a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom > pressL > > > ib.inf > > > > b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom > pressL > > > ib.inf > > > index 42b741c64b..4ed1d83a40 100644 > > > --- > > > > a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom > pressL > > > ib.inf > > > +++ > b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecom > pr > > > +++ essLib.inf > > > @@ -25,7 +25,7 @@ > > > # > > > # The following information is for reference only and not required = by the > build tools. > > > # > > > -# VALID_ARCHITECTURES =3D IA32 X64 EBC > > > +# VALID_ARCHITECTURES =3D IA32 X64 AARCH64 ARM > > > > It looks you are doing 2 changes at once: > > - Add ARM/Aarch64 which were missing to VALID_ARCHITECTURES > > - Remove EBC (BZ#2338) >=20 > No. ARM/AARCH64 were already supported - but the comment had not > been updated. So I suggested that when the comment was updated, it was > updated to reflect actual reality rather than just drop the EBC. >=20 > (This would of course have been more clear in the diffs if the SetupGit.p= y > script had been executed in the contributor's check-out, making the diff > show the sections being modified.) >=20 > / > Leif >=20 > > Do you mind splitting this patch in 2 logical ones? > > (Maybe it is cleaner to first fix BZ#2338, then add the missing archs. > > > > > # > > > [Sources] > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > > b/MdeModulePkg/MdeModulePkg.dsc index 4320839abf..f7dbb27ce2 > 100644 > > > --- a/MdeModulePkg/MdeModulePkg.dsc > > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > > @@ -299,7 +299,6 @@ > > > > MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf > > > > MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerL > ibNull.inf > > > > > > > MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSer > > > ialPortPpi.inf > > > - > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr > essLib.inf > > > > MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLib > ReportStatusCode.inf > > > > MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf > > > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > > @@ -433,6 +432,7 @@ > > > [Components.IA32, Components.X64, Components.ARM, > Components.AARCH64] > > > > > > > MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompr > es > > > sLib.inf > > > + > > > + > MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr > essL > > > + ib.inf > > > MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > > > MdeModulePkg/Core/Dxe/DxeMain.inf { > > > > > > > >