From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.11250.1579006724397239110 for ; Tue, 14 Jan 2020 04:58:44 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 04:58:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,432,1571727600"; d="scan'208";a="248487130" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 14 Jan 2020 04:58:44 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Jan 2020 04:58:44 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 14 Jan 2020 20:58:42 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Tue, 14 Jan 2020 20:58:42 +0800 From: "Liming Gao" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Haug, Brian R" , "Dong, Eric" Subject: Re: [patch] MdeModulePkg/Setup: Update opcode number variable type to UINTN Thread-Topic: [patch] MdeModulePkg/Setup: Update opcode number variable type to UINTN Thread-Index: AQHVyriVmaAp3LvgyE2kxXqweCEsVKfqHv5w Date: Tue, 14 Jan 2020 12:58:42 +0000 Message-ID: <12a0a5730f124545af10636cf5d48550@intel.com> References: <20200114085647.1796-1-dandan.bi@intel.com> In-Reply-To: <20200114085647.1796-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmNjNTA2MzQtMGQyNy00MzZjLThmNTctM2RjMTc5MmEyOGVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmROcnNvSXZpUGVGN3ExZ2ppcVhvalZSTERXMVBQVzFtQldsVDJ6djMraVlQblBCUmlsR1hERFZ2dkxRaCt1QSJ9 dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, January 14, 2020 4:57 PM > To: devel@edk2.groups.io > Cc: Haug, Brian R ; Gao, Liming ; Dong, Eric > Subject: [patch] MdeModulePkg/Setup: Update opcode number variable type t= o UINTN >=20 > From: Brian R Haug >=20 > Update data type of variables which save the opcode numbers > to UINTN, in case some configuration module has lots of > configuration items. >=20 > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Brian R Haug > Reviewed-by: Dandan Bi > --- > .../Universal/SetupBrowserDxe/IfrParse.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c b/MdeModul= ePkg/Universal/SetupBrowserDxe/IfrParse.c > index 891b95cf9f..edb6a0fc4c 100644 > --- a/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/IfrParse.c > @@ -1,17 +1,17 @@ > /** @file > Parser for IFR binary encoding. >=20 > -Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> +Copyright (c) 2007 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ >=20 > #include "Setup.h" >=20 > -UINT16 mStatementIndex; > -UINT16 mExpressionOpCodeIndex; > +UINTN mStatementIndex; > +UINTN mExpressionOpCodeIndex; > EFI_QUESTION_ID mUsedQuestionId; > extern LIST_ENTRY gBrowserStorageList; > /** > Initialize Statement header members. >=20 > @@ -1104,16 +1104,16 @@ IsUnKnownOpCode ( >=20 > **/ > VOID > CountOpCodes ( > IN FORM_BROWSER_FORMSET *FormSet, > - IN OUT UINT16 *NumberOfStatement, > - IN OUT UINT16 *NumberOfExpression > + OUT UINTN *NumberOfStatement, > + OUT UINTN *NumberOfExpression > ) > { > - UINT16 StatementCount; > - UINT16 ExpressionCount; > + UINTN StatementCount; > + UINTN ExpressionCount; > UINT8 *OpCodeData; > UINTN Offset; > UINTN OpCodeLen; >=20 > Offset =3D 0; > @@ -1167,12 +1167,12 @@ ParseOpCodes ( > FORMSET_STORAGE *Storage; > FORMSET_DEFAULTSTORE *DefaultStore; > QUESTION_DEFAULT *CurrentDefault; > QUESTION_OPTION *CurrentOption; > UINT8 Width; > - UINT16 NumberOfStatement; > - UINT16 NumberOfExpression; > + UINTN NumberOfStatement; > + UINTN NumberOfExpression; > EFI_IMAGE_ID *ImageId; > BOOLEAN SuppressForQuestion; > BOOLEAN SuppressForOption; > UINT16 DepthOfDisable; > BOOLEAN OpCodeDisabled; > -- > 2.18.0.windows.1