From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web12.4169.1622103904066685964 for ; Thu, 27 May 2021 01:25:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DPOE+O5s; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622103903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6UzBhwxe9d1Axoj5Jf11yHwJJFt5SjiE7H/++l4RRnM=; b=DPOE+O5sIFSHK8en7sNqLD9t8xT2SPmUfP76vrGyd21ZWP62t3WbYT/tefhhTaNmVzmsQ8 wtHRHrx+y5uiuVMVMfHlhhAhpxm6SQV83RTCZWkBHFZbZEoaAROzFytoUPqnNabGBW82JI t96U9UkW6arOT2rWgCrd7XE9fviOnwI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-RioFxn3OOWqkfuavwBjkxQ-1; Thu, 27 May 2021 04:25:01 -0400 X-MC-Unique: RioFxn3OOWqkfuavwBjkxQ-1 Received: by mail-wm1-f69.google.com with SMTP id 19-20020a05600c2313b0290193637766d9so1219103wmo.7 for ; Thu, 27 May 2021 01:25:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6UzBhwxe9d1Axoj5Jf11yHwJJFt5SjiE7H/++l4RRnM=; b=KhEdc0TTPIjy8LdHEOAj41hEJ8/SLt3UGrixV1ZSXad10VQ34IuXxS4wPJwKVY7jke Lo6715G6XamiNkC89pybF8YRdVgjKWHOFOtPosYIltpS7zOB9fNxENxC6D47SOjnZ7uk nRgF2mUQeQYRb49OK88APkNjyy2vbWOqXaUuP3ajFMNSuTD32NJEmhZTCn4LSE8l40Ve k+L9x2L+J3GVGTc4ogcO8DmE8JwwONFNF/LeTycpCtbFk98uADOZA/loTue3dKFSXwB1 3JuR0S82S+dfWDhVO9+6dfrg+ebGRzTkIPv3zVSEi8Y+MAn/K51yf7kD5ou84xx+9mc7 E4dA== X-Gm-Message-State: AOAM5331a6WGRtUCozJ5k80vcGGx8mwcdrCgum3GfNPucI+y5AGadC0v 0E46EEWakErJizFx/yzweEhrmxXO6WwoDshsOofDCg26FomHUA+uv/+oB7CT7VYSC7nS2GjWhTA SyuB9uIKK1wgqUQ== X-Received: by 2002:a05:600c:3515:: with SMTP id h21mr7215232wmq.148.1622103899990; Thu, 27 May 2021 01:24:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjfoEQmKqKlANca4cvztiD9Ns/MzOxh6o8pVrMPWZ9GyfX2bPct1FuD6p9VVoMEx37OLSKbw== X-Received: by 2002:a05:600c:3515:: with SMTP id h21mr7215222wmq.148.1622103899866; Thu, 27 May 2021 01:24:59 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id h8sm2062712wrw.85.2021.05.27.01.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:24:59 -0700 (PDT) Subject: Re: [PATCH 06/43] OvmfPkg/AcpiPlatformDxe: fix header file warts To: Laszlo Ersek , devel@edk2.groups.io Cc: Ard Biesheuvel , Jordan Justen References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-7-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <12a590a8-9387-68b8-4eec-c68f0d2ad815@redhat.com> Date: Thu, 27 May 2021 10:24:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-7-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > - Remove the leading underscores from the #include guard macro names; > clean up the names in general. > > - Remove the useless "Include/" directory prefix from the public header > pathnames. > > - Fix incorrect file-top comment. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 6 +++--- > OvmfPkg/AcpiPlatformDxe/QemuLoader.h | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daude