From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.1416.1613766686338692361 for ; Fri, 19 Feb 2021 12:31:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Bo5js2o/; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613766685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3/uOy6bGkx6XJR1KLjY4bhXwfyXdqIRgwPc3jNSaQpg=; b=Bo5js2o/vLr0oIqBEz3EFNPJ6t2nUn1juZ9goTTXRUQEx1bTecuAKQJhZaDlKWS1hdM5BX sUBAJ9lxnxglid8xTH9FS3Svzwa7XCSgeJmtb72KSuBZ55svbrDxWNubTDnmQXh+LFvs0q aODO2uaVFOQVuwufuBSfDOsCR8jG/CE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-294-zXHf_xsGMlGV-YapG7KFLA-1; Fri, 19 Feb 2021 15:31:21 -0500 X-MC-Unique: zXHf_xsGMlGV-YapG7KFLA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 68F60801965; Fri, 19 Feb 2021 20:31:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-87.ams2.redhat.com [10.36.113.87]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BE4A5D720; Fri, 19 Feb 2021 20:31:18 +0000 (UTC) Subject: Re: [PATCH v3 2/5] UefiCpuPkg/SmmCpuFeaturesLib: Rename SmmCpuFeaturesLib.c To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar References: <20210217213227.1277-1-mikuback@linux.microsoft.com> <20210217213227.1277-3-mikuback@linux.microsoft.com> From: "Laszlo Ersek" Message-ID: <12c4e323-c0d9-e78c-3449-ddc0257431b6@redhat.com> Date: Fri, 19 Feb 2021 21:31:17 +0100 MIME-Version: 1.0 In-Reply-To: <20210217213227.1277-3-mikuback@linux.microsoft.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/17/21 22:32, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > This change renames SmmCpuFeaturesLib.c to SmmCpuFeaturesLibCommon.c > to better convey that this file contains library implementation > common to all library instances. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Michael Kubacki > --- > UefiCpuPkg/Library/SmmCpuFeaturesLib/{SmmCpuFeaturesLib.c => SmmCpuFeaturesLibCommon.c} | 2 +- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 2 +- > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > similarity index 96% > rename from UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > rename to UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > index 75bde752785a..36c48310c31e 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > @@ -1,5 +1,5 @@ > /** @file > -The CPU specific programming for PiSmmCpuDxeSmm module. > +Implementation shared across all library instances. > > Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > index a6d8467d26aa..7ebb0b0ef011 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > @@ -18,7 +18,7 @@ [Defines] > > [Sources] > CpuFeaturesLib.h > - SmmCpuFeaturesLib.c > + SmmCpuFeaturesLibCommon.c > SmmCpuFeaturesLibNoStm.c > > [Packages] > diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf > index 89cd252ef44e..78f8e4b42c44 100644 > --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf > +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf > @@ -19,7 +19,7 @@ [Defines] > > [Sources] > CpuFeaturesLib.h > - SmmCpuFeaturesLib.c > + SmmCpuFeaturesLibCommon.c > SmmStm.c > SmmStm.h > > Reviewed-by: Laszlo Ersek