From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth against 0
Date: Tue, 3 Jul 2018 10:02:34 +0800 [thread overview]
Message-ID: <12c5b766-09bd-998e-ac1f-74741bf75f33@Intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB609B4@shsmsx102.ccr.corp.intel.com>
On 7/2/2018 6:05 PM, Zeng, Star wrote:
> Please add reference to bugzilla link into the commit log.
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=944
OK
>
> Another, is there any reason to only add debug message for " if ((BmpHeader->PixelHeight == 0) || (BmpHeader->PixelWidth == 0)) { ", but not " if ((PixelHeight == 0) || (PixelWidth == 0)) { " ???
PixelHeight and PixelWidth are passed in from caller directly.
But when caller passes in BmpImage buffer, it doesn't know the format
of the BMP header, so a debug message is shown to tell caller what happens.
--
Thanks,
Ray
next prev parent reply other threads:[~2018-07-03 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 7:36 [PATCH 0/2] Fix bugs in BmpSupportLib Ruiyu Ni
2018-06-25 7:36 ` [PATCH 1/2] MdeModulePkg/BmpSupportLib: Correct debug message Ruiyu Ni
2018-07-02 10:03 ` Zeng, Star
2018-06-25 7:36 ` [PATCH 2/2] MdeModulePkg/BmpSupportLib: Check PixelHeight/PixelWidth against 0 Ruiyu Ni
2018-07-02 10:05 ` Zeng, Star
2018-07-03 2:02 ` Ni, Ruiyu [this message]
2018-07-03 2:10 ` Zeng, Star
2018-07-03 2:16 ` Ni, Ruiyu
2018-07-03 2:27 ` Zeng, Star
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c5b766-09bd-998e-ac1f-74741bf75f33@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox