From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mx.groups.io with SMTP id smtpd.web10.16085.1679049394227460310 for ; Fri, 17 Mar 2023 03:36:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=dzOHJ1eG; spf=pass (domain: bsdio.com, ip: 64.147.123.20, mailfrom: rebecca@bsdio.com) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id CCF4332000EB; Fri, 17 Mar 2023 06:36:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 17 Mar 2023 06:36:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679049392; x=1679135792; bh=/TCO1cX3FatWMbRKO9FK7X+O5xK5+hfjI8J bftbhCKY=; b=dzOHJ1eGXUIBGYb6gN2023qUQKnqK6QWdY1lP7I28W74QSmFCwr MSB1eDfcnSNRZzniEqWzVFGDYAel1/J29HXQGAQzrDyhpPY6F+ABMWhX6hZgvSvQ 1GZLfV/3dl8e316HYAOFrpWTtcyumx2ZCBtfbhMxCpOX2lGyVlWBWJMt4YlvIEo0 0BEtmU8qYNwjbCN0pueJz4LmUWLfXEFC/5BP3dyNafcD0m8v8QB9XiMyPmnzsZmW +vmLR5wv8v0A2+04TbLadoty9SDvJMk8sZLfG8e6bLtR3z01ahiFnWF8PU2dmXoW yu4sj5O8uo5dwUSx+hkQFhU6Kal2L81GWBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679049392; x=1679135792; bh=/TCO1cX3FatWMbRKO9FK7X+O5xK5+hfjI8J bftbhCKY=; b=dJFNe/+WBdEqg9uy3hf+gHloadlqjI/prGfwu0L9vc7oGXrcRLS JXduaV/VEDmPQJxVPL9eG368G1M3snmz6EkO2/CaBFcsVL/aZsK0SKr/0pWwjHWO XEtQ9+OBz3sAL4iACLPGesW/0ZApbzDiOFVQ5HG/2wxd+gGwf166Ck3RZqc/Q8TW s/dFFADHBqXKSy6Ekm8whoXSQpm7gutK0humukz2xzgJCSE6ZO26aNUXwTS27hno L1sgcfdFfULoeCpSnjAPcrf2uQTop6zPI/JDFnOUNc4V3IeD/ufeYawMZhHbsUIP S4w7nWfwAl85HGnmxUTGbNMxRZJIU8hNAvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefvddgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttdefjeenucfhrhhomheptfgvsggvtggtrgcuvehrrghnuceorhgvsggvtggtrges sghsughiohdrtghomheqnecuggftrfgrthhtvghrnhepheelkefgudetudegheegfffghf etfefhhfetteefveehgfdvjeehtdfhffeiffelnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Mar 2023 06:36:31 -0400 (EDT) Message-ID: <12d55f42-7192-a1dd-c125-35c41ada2f87@bsdio.com> Date: Fri, 17 Mar 2023 04:36:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [edk2-platforms] Enable GitHub PR, protected branches, and 'push' label To: Gerd Hoffmann , devel@edk2.groups.io Cc: michael.d.kinney@intel.com, =?UTF-8?Q?Marvin_H=c3=a4user?= References: <1336.1678919068042837404@groups.io> <20230317093347.gi65s3qu5vzzilzn@sirius.home.kraxel.org> From: "Rebecca Cran" In-Reply-To: <20230317093347.gi65s3qu5vzzilzn@sirius.home.kraxel.org> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I like that proposed workflow. I've also been wondering if we could consider choosing a different product for patch reviews that supports our desired workflow better, such as Gitlab or Phorge (the new Phabricator project). If anyone would be willing to donate money for colocation, I'd be happy to move one or more of my servers into a datacenter and use them for hosting TianoCore services. -- Rebecca Cran On 3/17/23 3:33 AM, Gerd Hoffmann wrote: > On Thu, Mar 16, 2023 at 01:59:49PM -0600, Rebecca Cran wrote: >> Is this still a requirement since Laszlo's departure from the project? >> >> I seem to recall it was him who made it a sticking point of moving to a >> GitHub PR workflow originally with the requirement to have emails of >> everything. > I think it is very useful to have everything on the mailing list for > a number of reasons: > > (1) In my experience reviewing patches, especially more complex ones, > works better in email than in github PR workflows. > (2) github doesn't preserve stuff like a mail archive does. When a > patch series goes through multiple revision github only preserves > the latest revision which was actually merged. > (3) Search engines seem to be better in indexing mail list archives > than github pull requests. > > Nevertheless I see some room for improvement in our current workflow. > Developers often open a PR anyway for to run the CI. So maybe we could > automate sending the emails and also avoid running CI twice by avoiding > both developer and maintainer opening a PR, with a workflow like this: > > * developer opens a draft PR to run CI for the patch series. > * when the series passes CI and is ready un-draft the PR. > * github action sends the patch series to the edk2-devel list > for review (maybe only after CI passed ...). > * patch review happens on the list. > * in case the developer pushes updates to the branch in response to > review comments the github action posts v2/v3 of the series too. > * once review is done merge the PR. > > take care, > Gerd >