Re: [PATCH v3 0/7] Add platform hook for ultimate boot failure.

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 7/4/2018 9:08 AM, Ni, Ruiyu wrote:
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek [mailto:lersek@redhat.com]
>> Sent: Tuesday, July 3, 2018 11:53 PM
>> To: Ni, Ruiyu <ruiyu.ni@intel.com>
>> Cc: edk2-devel@lists.01.org; Leif Lindholm (Linaro address)
>> <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Wei,
>> David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>
>> Subject: Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure.
>>
>> Hi Ray,
>>
>> On 07/03/18 08:37, Ruiyu Ni wrote:
>>> Ruiyu Ni (7):
>>>    MdeModulePkg/PlatformBootManager: Add
>> PlatformBootManagerUnableToBoot
>>>    CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot
>>>    OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot
>>>    Nt32Pkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot
>>>    QuarkPlatform/PlatformBDS: Implement
>> PlatformBootManagerUnableToBoot
>>>    MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging"
>>>    MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot()
>>>
>>>   .../PlatformBootManagerLib/PlatformBootManager.c   | 19 ++++++-
>>>   .../Include/Library/PlatformBootManagerLib.h       | 13 +++++
>>>   .../PlatformBootManager.c                          | 19 ++++++-
>>>   MdeModulePkg/Universal/BdsDxe/BdsEntry.c           | 61 ++--------------------
>>>   .../PlatformBootManagerLib/PlatformBootManager.c   | 19 ++++++-
>>>   .../Library/PlatformBootManagerLib/BdsPlatform.c   | 61
>> +++++++++++++++++++++-
>>>   .../PlatformBootManagerLib/PlatformBootManager.c   | 19 ++++++-
>>>   7 files changed, 150 insertions(+), 61 deletions(-)
>>>
>>
>> thanks a lot for this version as well!
>>
>> It seems we have the following PlatformBootManagerLib instances in the
>> edk2 tree:
>>
>>    ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>>    ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>>
>> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerL
>> ib.inf
>>
>> MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManagerLi
>> bNull.inf
>>    Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>>    OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>>
>> QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
>> nf
>>    Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
>>
>> This series updates all but ArmPkg, ArmVirtPkg and Vlv2TbltDevicePkg. So I think
>> three more patches would be necessary, before patch #6.
> I tried to search all PlatformBootManagerAfterConsole() to locate all instances
> of PlatformBootManagerLib.
> Now it seems I still missed three.
> I will make an updated patch and send V4.
> 
>>
>> Originally, with the registration pattern, I offered to port the OvmfPkg update to
>> ArmVirtPkg myself, later. However, with the present pattern, these three
>> platforms would stop building, so I think they should be updated before we
>> commit patches #6 and #7.
>>
>> For ArmPkg and Vlv2TbltDevicePkg, I *think* the Null implementation ("do
>> nothing") is appropriate. (I'm CC'ing those package maintainers). For ArmVirtPkg,
>> duplicating the OvmfPkg approach would be correct.
Vlv2TbltDevicePkg is still using old IntelFrameworkModulePkg/BdsDxe.
So I will just update ArmPkg and ArmVirtPkg.

>>
>> Can you take on updating these three platforms as well? Or can I help somehow
>> with it? (It's tricky because the three platform patches that I could post should
>> go in the middle of the series, neither before nor
>> after.)
>>
>> Thank you!
>> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 


-- 
Thanks,
Ray