From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 005C62097FAA8 for ; Tue, 3 Jul 2018 18:45:57 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 18:45:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,306,1526367600"; d="scan'208";a="213230755" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by orsmga004.jf.intel.com with ESMTP; 03 Jul 2018 18:45:56 -0700 To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , "Wei, David" References: <20180703063743.373172-1-ruiyu.ni@intel.com> <9e74a4d8-60b8-eeb9-8acd-2ff3418c9e83@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5BD5FBE6@SHSMSX104.ccr.corp.intel.com> From: "Ni, Ruiyu" Message-ID: <12ea03d0-24db-f9fd-ea30-94a817cb17e6@Intel.com> Date: Wed, 4 Jul 2018 09:46:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BD5FBE6@SHSMSX104.ccr.corp.intel.com> Subject: Re: [PATCH v3 0/7] Add platform hook for ultimate boot failure. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 01:45:58 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/4/2018 9:08 AM, Ni, Ruiyu wrote: > > >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Tuesday, July 3, 2018 11:53 PM >> To: Ni, Ruiyu >> Cc: edk2-devel@lists.01.org; Leif Lindholm (Linaro address) >> ; Ard Biesheuvel ; Wei, >> David ; Guo, Mang >> Subject: Re: [edk2] [PATCH v3 0/7] Add platform hook for ultimate boot failure. >> >> Hi Ray, >> >> On 07/03/18 08:37, Ruiyu Ni wrote: >>> Ruiyu Ni (7): >>> MdeModulePkg/PlatformBootManager: Add >> PlatformBootManagerUnableToBoot >>> CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot >>> OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot >>> Nt32Pkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot >>> QuarkPlatform/PlatformBDS: Implement >> PlatformBootManagerUnableToBoot >>> MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging" >>> MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot() >>> >>> .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++++++- >>> .../Include/Library/PlatformBootManagerLib.h | 13 +++++ >>> .../PlatformBootManager.c | 19 ++++++- >>> MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 61 ++-------------------- >>> .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++++++- >>> .../Library/PlatformBootManagerLib/BdsPlatform.c | 61 >> +++++++++++++++++++++- >>> .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++++++- >>> 7 files changed, 150 insertions(+), 61 deletions(-) >>> >> >> thanks a lot for this version as well! >> >> It seems we have the following PlatformBootManagerLib instances in the >> edk2 tree: >> >> ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> >> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerL >> ib.inf >> >> MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManagerLi >> bNull.inf >> Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> >> QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i >> nf >> Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf >> >> This series updates all but ArmPkg, ArmVirtPkg and Vlv2TbltDevicePkg. So I think >> three more patches would be necessary, before patch #6. > I tried to search all PlatformBootManagerAfterConsole() to locate all instances > of PlatformBootManagerLib. > Now it seems I still missed three. > I will make an updated patch and send V4. > >> >> Originally, with the registration pattern, I offered to port the OvmfPkg update to >> ArmVirtPkg myself, later. However, with the present pattern, these three >> platforms would stop building, so I think they should be updated before we >> commit patches #6 and #7. >> >> For ArmPkg and Vlv2TbltDevicePkg, I *think* the Null implementation ("do >> nothing") is appropriate. (I'm CC'ing those package maintainers). For ArmVirtPkg, >> duplicating the OvmfPkg approach would be correct. Vlv2TbltDevicePkg is still using old IntelFrameworkModulePkg/BdsDxe. So I will just update ArmPkg and ArmVirtPkg. >> >> Can you take on updating these three platforms as well? Or can I help somehow >> with it? (It's tricky because the three platform patches that I could post should >> go in the middle of the series, neither before nor >> after.) >> >> Thank you! >> Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > -- Thanks, Ray