From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3C6C9941B83 for ; Thu, 25 Jan 2024 19:25:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=p/vXPZ62S3HFz8oQ2Sx2XVE9ZwZ9d6g/Xp63LyEed1w=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706210728; v=1; b=KhEtGNcm1Goc0rTSIpzND1np7cGK2vYr+FfvSu0/XKY/iDqVGMWX6vtJgLpEC9Kem0FuhUxP VHwasw/ws/jqJii/n+xuMfMPIW+58gZQy+2Emw06XCF5BfSIsM5OLd9lUvdYnlm0AfaokpZmB4S x32WS7OmvPZd3Hxr18BgeTvI= X-Received: by 127.0.0.2 with SMTP id 1zJpYY7687511xzz8wfaJF65; Thu, 25 Jan 2024 11:25:28 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.27789.1706210727902316989 for ; Thu, 25 Jan 2024 11:25:28 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-Ij2JA7lbM-GNsOASv6P4Qw-1; Thu, 25 Jan 2024 14:25:20 -0500 X-MC-Unique: Ij2JA7lbM-GNsOASv6P4Qw-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 574AF1C05154; Thu, 25 Jan 2024 19:25:20 +0000 (UTC) X-Received: from [10.39.195.100] (unknown [10.39.195.100]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4E812028CD4; Thu, 25 Jan 2024 19:25:18 +0000 (UTC) Message-ID: <12f76b60-adcb-5695-adf8-ae1b69bcb316@redhat.com> Date: Thu, 25 Jan 2024 20:25:17 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SMM: Support to unregister SMI handler inside SMI handler To: "Ni, Ray" , "devel@edk2.groups.io" , "Liu, Zhiguang" Cc: Liming Gao , "Wu, Jiaxin" , Ard Biesheuvel , Sami Mujawar References: <20240124040301.2176-1-zhiguang.liu@intel.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IWDxoQDmm4emUBEJCXMmu8n3x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KhEtGNcm; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/25/24 13:05, Ni, Ray wrote: > Laszlo, > SMI handler is called from SmmCore. > So SmmCore knows which handle is passed to the SMI handler. > How about let Unregister() rejects the request coming from a SMI handler = which unregisters other handles? >=20 > A "gCurrentSmiHandle" can be assigned before calling the SMI handler and = set to NULL when it returns. > Unregister() compares the handle against gCurrentSmiHandle if it's not NU= LL. Sounds safe enough. I don't know if it conforms to the spec however (although we might just choose not to care about that). Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114458): https://edk2.groups.io/g/devel/message/114458 Mute This Topic: https://groups.io/mt/103925794/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-