From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BDD869414DE for ; Sun, 31 Mar 2024 10:31:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Qgkok5tC7HAxyciQ/WEotDkIDGY9YQcUCkEYJErYBlc=; c=relaxed/simple; d=groups.io; h=Subject:To:From:User-Agent:MIME-Version:Date:References:In-Reply-To:Message-ID:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1711881098; v=1; b=okW4ax+PGEfBlN4xFXKDUm99HiOHtIIkS0/vndxI4Z9P8kgQgcI37DbjyD1+3xObScReqZ+8 /05ywl4gDJJOAxfdr2sTuNueZfkcfRvBRkGVaTRObSJqTMronGmphZq/BCAAKNo9ZZZ6eSsI6Wp oYurMTbNbY9W3cMvqWhIhhXx38L8MVBr/8e/B2k7LvKT5eI4XvMQ9tXNJx4tVf41GbzWWxUK/Ld 6lFtWQk74YwZ77lmaVbhI4UVwc3HzKZ8L45LN5n83GnC4ieP93qSweJ6Vg2TVtWrwqc/9VY2r3O dfGe50UVng2ZfdanDfsh52S7IKb5AOZi73HFZU+6/4jzQ== X-Received: by 127.0.0.2 with SMTP id jCKrYY7687511xXyewpRFSEz; Sun, 31 Mar 2024 03:31:38 -0700 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v5 4/9] Platform/Sgi: Introduce a flag to enable PCIe support for RD Platforms To: "Prabin CA" , devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.13) X-Originating-Platform: Mac Safari 17.1 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Sun, 31 Mar 2024 03:31:37 -0700 References: <20240311131416.823580-5-prabin.ca@arm.com> In-Reply-To: <20240311131416.823580-5-prabin.ca@arm.com> Message-ID: <13077.1711881097714512032@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZCzzYGdF4chfLZsuuzHlmOnQx7686176AA= Content-Type: multipart/alternative; boundary="pQfEZn3fojErKD6xmT97" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=okW4ax+P; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --pQfEZn3fojErKD6xmT97 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Prabin, Thank you for this patch. On Mon, Mar 11, 2024 at 06:14 AM, Prabin CA wrote: >=20 > #define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS =3D > \ > - ((14 + (FixedPcdGet32 (PcdChipCount) * 2)) + =3D > \ > + ((13 + (FixedPcdGet32 (PcdChipCount) * 2)) + =3D > \ > + (FeaturePcdGet (PcdPcieEnable)) + =3D > \ > (FixedPcdGet32 (PcdIoVirtSocExpBlkUartEnable) * =3D > \ > FixedPcdGet32 (PcdChipCount) * 2)) > =3D20 This is not correct FeaturePcdGet() returns a boolean value. Please update = this code accordingly. Regards, Sami Mujawar -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117257): https://edk2.groups.io/g/devel/message/117257 Mute This Topic: https://groups.io/mt/104862630/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --pQfEZn3fojErKD6xmT97 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Prabin,

Thank you for this patch.

On Mon, Mar 11,= 2024 at 06:14 AM, Prabin CA wrote:
#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS =3D
\
- ((= 14 + (FixedPcdGet32 (PcdChipCount) * 2)) + =3D
\
+ ((13 + (FixedP= cdGet32 (PcdChipCount) * 2)) + =3D
\
+ (FeaturePcdGet (PcdPcieEna= ble)) + =3D
\
(FixedPcdGet32 (PcdIoVirtSocExpBlkUartEnable) * =3D=
\
FixedPcdGet32 (PcdChipCount) * 2))
=3D20
This is not correct FeaturePcdGet() returns a boolean value. Please update = this code accordingly.

Regards,

Sami Mujawar  
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117257) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--pQfEZn3fojErKD6xmT97--