[PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[Satoshi Tanda]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3325

AsmReadSs() in Ia32/GccInlinePriv.c and X64/GccInlinePriv.c return the
DS segment selector value instead of SS.

Signed-off-by: Satoshi Tanda <tanda.sat@gmail.com>
---
 MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 2 +-
 MdePkg/Library/BaseLib/X64/GccInlinePriv.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c b/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c
index 40e8c08beb..b8b5b85e73 100644
--- a/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c
+++ b/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c
@@ -902,7 +902,7 @@ AsmReadSs (
   UINT16  Data;
 
   __asm__ __volatile__ (
-    "mov  %%ds, %0"
+    "mov  %%ss, %0"
     :"=a" (Data)
     );
 
diff --git a/MdePkg/Library/BaseLib/X64/GccInlinePriv.c b/MdePkg/Library/BaseLib/X64/GccInlinePriv.c
index 244bd62ee6..c3feb9f922 100644
--- a/MdePkg/Library/BaseLib/X64/GccInlinePriv.c
+++ b/MdePkg/Library/BaseLib/X64/GccInlinePriv.c
@@ -911,7 +911,7 @@ AsmReadSs (
   UINT16  Data;
 
   __asm__ __volatile__ (
-    "mov  %%ds, %0"
+    "mov  %%ss, %0"
     :"=a" (Data)
     );
 
-- 
2.25.1

Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[Laszlo Ersek]

CC'ing the MdePkg maintainers (see "Maintainers.txt" and
"$EDK_TOOLS_PATH/Scripts/GetMaintainer.py").

On 05/24/21 06:50, Satoshi Tanda wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3325

(1) The BZ URL is incorrect; the right URL is

https://bugzilla.tianocore.org/show_bug.cgi?id=3405

But I think whoever merges this patch can update the BZ URL upon merge.


(2) Similarly, I think the subject should be clarified, upon merge:

  MdePkg/BaseLib: Fix AsmReadSs() with GCC toolchain

> 
> AsmReadSs() in Ia32/GccInlinePriv.c and X64/GccInlinePriv.c return the
> DS segment selector value instead of SS.
> 
> Signed-off-by: Satoshi Tanda <tanda.sat@gmail.com>
> ---
>  MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 2 +-
>  MdePkg/Library/BaseLib/X64/GccInlinePriv.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c b/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c
> index 40e8c08beb..b8b5b85e73 100644
> --- a/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c
> +++ b/MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c
> @@ -902,7 +902,7 @@ AsmReadSs (
>    UINT16  Data;
>  
>    __asm__ __volatile__ (
> -    "mov  %%ds, %0"
> +    "mov  %%ss, %0"
>      :"=a" (Data)
>      );
>  
> diff --git a/MdePkg/Library/BaseLib/X64/GccInlinePriv.c b/MdePkg/Library/BaseLib/X64/GccInlinePriv.c
> index 244bd62ee6..c3feb9f922 100644
> --- a/MdePkg/Library/BaseLib/X64/GccInlinePriv.c
> +++ b/MdePkg/Library/BaseLib/X64/GccInlinePriv.c
> @@ -911,7 +911,7 @@ AsmReadSs (
>    UINT16  Data;
>  
>    __asm__ __volatile__ (
> -    "mov  %%ds, %0"
> +    "mov  %%ss, %0"
>      :"=a" (Data)
>      );
>  
> 

With (1) and (2) fixed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Should this go into edk2-stable202105?

On one hand, this is clearly a bugfix. On the other hand, we're very
close to the tag, maybe something depends on the buggy behavior, and the
function has been broken since (at least) commit cf683fedc773
(2010-05-18). Personally I wouldn't rush it.

Thanks
Laszlo

Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[Satoshi Tanda]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

On Tue, May 25, 2021 at 05:16 AM, Laszlo Ersek wrote:

> 
> (1) The BZ URL is incorrect;

> 
> (2) Similarly, I think the subject should be clarified, upon merge

Let me know if anyone needs the updates of the patch on those (vs updating them inline at PR). I will do it if required.

> 
> Should this go into edk2-stable202105?

No, to me. I do not find a reason to rush it neither.

> 
> CC'ing the MdePkg maintainers (see "Maintainers.txt" and "$EDK_TOOLS_PATH/Scripts/GetMaintainer.py").
> 

This document should probably be updated to mention them later. Those are not explained.
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

Thanks for the reviewing this and guiding me on the process.

Satoshi

[-- Attachment #2: Type: text/html, Size: 1244 bytes --]

Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[Laszlo Ersek]

On 05/25/21 16:28, Satoshi Tanda wrote:
> On Tue, May 25, 2021 at 05:16 AM, Laszlo Ersek wrote:
> 
>>
>> (1) The BZ URL is incorrect;
> 
>>
>> (2) Similarly, I think the subject should be clarified, upon merge
> 
> Let me know if anyone needs the updates of the patch on those (vs updating them inline at PR). I will do it if required.

I'll leave that decision to the MdePkg owners.

> 
>>
>> Should this go into edk2-stable202105?
> 
> No, to me. I do not find a reason to rush it neither.
> 
>>
>> CC'ing the MdePkg maintainers (see "Maintainers.txt" and "$EDK_TOOLS_PATH/Scripts/GetMaintainer.py").
>>
> 
> This document should probably be updated to mention them later. Those are not explained.
> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

It is spelled out in the "unkempt git guide", in this section:

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-18

but indeed it's not part of the official (normative) article.

The problem with writing more documentation is that then you have to
keep more documentation up-to-date :/

Thanks,
Laszlo

> 
> Thanks for the reviewing this and guiding me on the process.
> 
> Satoshi
> 

Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[Satoshi Tanda]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

Could we get this patch reviewed and approved by required folks, or advise me how can I move forward?

Thanks!
Satoshi

[-- Attachment #2: Type: text/html, Size: 145 bytes --]

回复: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

I have updated BZ link and title in the commit message. 

 

Create PR https://github.com/tianocore/edk2/pull/1687

 

Thanks

Liming

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Satoshi Tanda
发送时间: 2021年6月4日 8:24
收件人: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

 

Could we get this patch reviewed and approved by required folks, or advise me how can I move forward? 

Thanks!
Satoshi




[-- Attachment #2: Type: text/html, Size: 4389 bytes --]

Re: [edk2-devel] 回复: [edk2-devel] [PATCH] MdePkg: Fix AsmReadSs() with GCC toolchain

[Satoshi Tanda]

[-- Attachment #1: Type: text/plain, Size: 20 bytes --]

Thank you, Liming!

[-- Attachment #2: Type: text/html, Size: 20 bytes --]