From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D873E941535 for ; Wed, 16 Aug 2023 10:25:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6W8KwAmvNtDxikJtbdOPgHewRgUO6/5Rpq5CJjagkJw=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject:MIME-Version:Thread-Topic:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692181541; v=1; b=MPywU5QGVA2Io2uPYOayZTOf179KyDB1gir1PVB7o0MtJLg31r83jXauG2qw75oz1muY2SAf PHrjDuxAs0lvga1Gh76RkyMPsu1z9NirWQeEKB3O64zgNQfBzcLtkwjo5ZPF11K738ee8x61b6s KWY6jCLSND2/WurFMzqQGUs8= X-Received: by 127.0.0.2 with SMTP id bX8tYY7687511xMYusvPUVm1; Wed, 16 Aug 2023 03:25:41 -0700 X-Received: from smtp238.sjtu.edu.cn (smtp238.sjtu.edu.cn [202.120.2.238]) by mx.groups.io with SMTP id smtpd.web11.157458.1692181540124167116 for ; Wed, 16 Aug 2023 03:25:40 -0700 X-Received: from mta91.sjtu.edu.cn (unknown [10.118.0.91]) by smtp238.sjtu.edu.cn (Postfix) with ESMTPS id 478BDD46; Wed, 16 Aug 2023 18:25:36 +0800 (CST) X-Received: from mstore108.sjtu.edu.cn (mstore101.sjtu.edu.cn [10.118.0.108]) by mta91.sjtu.edu.cn (Postfix) with ESMTP id C9E1C37C990; Wed, 16 Aug 2023 18:25:35 +0800 (CST) Date: Wed, 16 Aug 2023 18:25:35 +0800 (CST) From: "Qingyu Shang" <2931013282@sjtu.edu.cn> To: Sunil V L Cc: "Li, Yong" , devel@edk2.groups.io, "Warkentin, Andrei" Message-ID: <1317091074.1521292.1692181535408.JavaMail.zimbra@sjtu.edu.cn> In-Reply-To: References: <2c7b82749a9aff01393b230e216c5e5aee675dd1.1691750977.git.2931013282@sjtu.edu.cn> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBPdm1mUGtnL1Jpc2NWVmlydDogRml4IGlzc3VlcyBpbiBWYXJTdG9yZSBCbG9ja21hcCBjb25maWc=?= MIME-Version: 1.0 X-Originating-IP: [223.104.150.70] Thread-Topic: OvmfPkg/RiscVVirt: Fix issues in VarStore Blockmap config Thread-Index: LswDFe6XvBx3fTWYmK+2zPFSu6zrXQ== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,2931013282@sjtu.edu.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iz5CG2OryCVkx5GfpltXeVDUx7686176AA= Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MPywU5QG; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sunil,=20 Happy you like that! I will CC all the related maintainers by that python s= cript next time.=20 Thanks!=20 Qingyu=20 -----=D4=AD=CA=BC=D3=CA=BC=FE-----=20 =B7=A2=BC=FE=C8=CB: "Sunil V L" =20 =CA=D5=BC=FE=C8=CB: "Li, Yong" =20 =B3=AD=CB=CD: devel@edk2.groups.io, 2931013282@sjtu.edu.cn, "Warkentin, And= rei" =20 =D2=D1=B7=A2=CB=CD=D3=CA=BC=FE: =D0=C7=C6=DA=C8=FD, 8 =D4=C2 16, 2023 05:03= :00 PM=20 =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] OvmfPkg/RiscVVirt: Fix issues in Var= Store Blockmap config=20 On Wed, Aug 16, 2023 at 07:08:58AM +0000, Li, Yong wrote:=20 > Hi Sunil,=20 >=20 > Qingyu is from Penglai team, when we were working together in enabling St= andaloneMm variable service,=20 > we found an issue in OvmfPkg/RiscVVirt/VarStore.fdf.inc, in which the blo= ckmap config is not aligned with the value in=20 > OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c= , which is SIZE_256KB=20 >=20 > That mis-alignment won't cause any issue if the variable size is small an= d less than 0x1000, but if store more data in the flash device then it will= cause data loss issue during reboot.=20 > Once reboot if any FV header data is corrupted it will result the whole v= ariable system be re-initialized.=20 >=20 > Please help review the patch and give the comments, thanks=20 >=20 Hi Yong Li,=20 Thank you very much for providing the context. Sorry, I actually had=20 missed this.=20 Hi Quingyu Shang,=20 The patch LGTM. Thanks a lot for finding the issue and fixing it. In=20 future, could you please run BaseTools/Scripts/GetMaintainer.py on the=20 patches and CC all the people it lists using "Cc:" tag?=20 Reviewed-by: Sunil V L =20 Thanks!=20 Sunil=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107795): https://edk2.groups.io/g/devel/message/107795 Mute This Topic: https://groups.io/mt/100776646/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-