From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [PATCH V4 22/31] OvmfPkg: Update PlatformPei to support TDX To: Min Xu ,devel@edk2.groups.io From: "Vishal Annapurve" X-Originating-Location: Redmond, Washington, US (73.118.244.112) X-Originating-Platform: Linux Chrome 97 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 13 Jan 2022 18:37:11 -0800 References: In-Reply-To: Message-ID: <13205.1642127831663049922@groups.io> Content-Type: multipart/alternative; boundary="kejLoM14E795f3MB9u2i" --kejLoM14E795f3MB9u2i Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thanks Min for the reference of the firmware design guide. If VMM is expected to set it then issue I mentioned with CoreInitializeMemo= ryServices can be ignored. Though its mentioned in the design guide, I was confused by the current imp= lementation of TDX Qemu as per: https://github.com/intel/qemu-tdx/blob/tdx/hw/i386/tdvf-hob.c#L169 https://github.com/intel/qemu-tdx/blob/852a069e739a6ffae4f9dec17607a74690b0= e4af/hw/i386/tdvf-hob.h#L15 and config B patches: https://github.com/mxu9/edk2/commit/c5d5786290b2455c5a0a7e3515cf04ec2218d8a= 4#diff-7cb0d3ac758c9b92166d03049917116ca4a5cb012db99deb491f63c5c5562e0aR124 It's possible that I have incomplete view of Qemu implementation or Config = B patches. Regards, Vishal --kejLoM14E795f3MB9u2i Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thanks Min for the reference of the firmware design guide.

If VM= M is expected to set it then issue I mentioned with CoreInitializeMemorySer= vices can be ignored.

Though its mentioned in the design guide, = I was confused by the current implementation of TDX Qemu as per:
https://github.com/intel/qemu-tdx/blob/td= x/hw/i386/tdvf-hob.c#L169
https://github.com/intel/qemu-tdx/blob/8= 52a069e739a6ffae4f9dec17607a74690b0e4af/hw/i386/tdvf-hob.h#L15 &nb= sp;

and config B patches:
https://github.com/mxu9/edk2/commit/c5d5786290b2455c5a0a7e35= 15cf04ec2218d8a4#diff-7cb0d3ac758c9b92166d03049917116ca4a5cb012db99deb491f6= 3c5c5562e0aR124

It's possible that I have incomplete view of= Qemu implementation or Config B patches.

Regards,
Vishal --kejLoM14E795f3MB9u2i--