From: "Matthew Carlson" <macarl@microsoft.com>
To: Laszlo Ersek <lersek@redhat.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto
Date: Tue, 11 Aug 2020 19:27:36 -0700 [thread overview]
Message-ID: <13469.1597199256202235840@groups.io> (raw)
In-Reply-To: <cf650b80-a046-3c48-97a6-006fb1f54bc4@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Thank you for the helpful comments Lazlo!
I sent out an updated series (v5) that fixes the things you mentioned. I added more description, so hopefully that helps.
Sorry I didn't notice BhyvePkg, I thought you couldn't have packages under other packages, so I didn't think to check for other DSC's. It should be fixed up like the other Ovmf DSC's.
I've been following your excellent guide for sending mailing list patches (Lazlo's Guide). ( https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers ) Is there a better way to get all the CC's from all the patches other than just copy and pasting them all? Perhaps the GetMaintainers.py where you specify multiple commits? Specifying a range didn't produce the desired behavior.
--
- Matthew Carlson
[-- Attachment #2: Type: text/html, Size: 882 bytes --]
next prev parent reply other threads:[~2020-08-12 2:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 2:21 [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib Matthew Carlson
2020-08-11 2:21 ` [PATCH v4 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib Matthew Carlson
2020-08-11 2:21 ` [PATCH v4 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe Matthew Carlson
2020-08-11 2:21 ` [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto Matthew Carlson
2020-08-11 8:22 ` Ard Biesheuvel
2020-08-11 16:09 ` [edk2-devel] " Laszlo Ersek
2020-08-11 16:15 ` Laszlo Ersek
2020-08-12 2:27 ` Matthew Carlson [this message]
2020-08-12 10:05 ` Laszlo Ersek
2020-08-15 5:33 ` Rebecca Cran
2020-08-11 2:21 ` [PATCH v4 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg Matthew Carlson
2020-08-11 16:13 ` [edk2-devel] " Laszlo Ersek
2020-08-11 2:22 ` [PATCH v4 5/5] CryptoPkg: OpensslLib: Use RngLib to generate entropy in rand_pool Matthew Carlson
2020-08-11 11:33 ` [edk2-devel] [PATCH v4 0/5] Use RngLib instead of TimerLib for OpensslLib Guomin Jiang
2020-08-12 2:21 ` Matthew Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13469.1597199256202235840@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox