Re: [edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

["Lin, Derek (HPS SW)" <derek.lin2@hpe.com>]

[-- Attachment #1.1: Type: text/plain, Size: 820 bytes --]

Hi Steven,

Thanks for the fix!
I've tried your patch with a minor fix as attached.
1            2           3                4
Build Duration:        00:05:51  00:03:47  00:05:15  00:04:31
AutoGen Duration:  00:03:32  00:03:08  00:03:14  00:03:16
Make Duration:       00:01:50  00:00:16  00:01:29  00:00:50
GenFds Duration:   00:00:30  00:00:22  00:00:31  00:00:23

1: clean build with patch and --hash
2: incremental build
3. clean build without patch and without --hash
4. incremental build

BTW, this data cannot compare with previous data I provided because they are built in different environment.

In general, the result is as you said that it fix --hash functionality, but not as quick as before.
Also the cost of --hash in clean build is increased.

[-- Attachment #1.2: Type: text/html, Size: 1248 bytes --]

[-- Attachment #2: build.patch --]
[-- Type: application/octet-stream, Size: 1067 bytes --]

From 785f105b6ae6582996cb1db36f182d796729590c Mon Sep 17 00:00:00 2001
From: Derek Lin <derek.lin2@hpe.com>
Date: Fri, 27 Sep 2019 14:06:04 +0800
Subject: [PATCH] Remove gModuleBuildTracking

---
 BaseTools/Source/Python/AutoGen/GenMake.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/GenMake.py b/BaseTools/Source/Python/AutoGen/GenMake.py
index 584156dab97..4ed46de888c 100755
--- a/BaseTools/Source/Python/AutoGen/GenMake.py
+++ b/BaseTools/Source/Python/AutoGen/GenMake.py
@@ -968,8 +968,6 @@ def ProcessBuildTargetList(self):
         for aFile in headerFileDependencySet:
             if aFile in headerFilesInMetaFileSet:
                 continue
-            if GlobalData.gUseHashCache:
-                GlobalData.gModuleBuildTracking[self._AutoGenObject] = 'FAIL_METAFILE'
             EdkLogger.warn("build","Module MetaFile [Sources] is missing local header!",
                         ExtraData = "Local Header: " + aFile + " not found in " + self._AutoGenObject.MetaFile.Path
                         )