From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908
To: Steven Shi <steven.shi@intel.com>,devel@edk2.groups.io
From: "Lin, Derek (HPS SW)" <derek.lin2@hpe.com>
X-Originating-Location: US (15.211.153.76)
X-Originating-Platform: Windows Chrome 76
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Fri, 27 Sep 2019 00:57:15 -0700
References: <06C8AB66E78EE34A949939824ABE2B3140183293@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <06C8AB66E78EE34A949939824ABE2B3140183293@shsmsx102.ccr.corp.intel.com>
Message-ID: <13576.1569571035464933693@groups.io>
X-Groupsio-MsgNum: 48208
Content-Type: multipart/mixed; boundary="bjDrB15IX9nPKaV0fqCm"

--bjDrB15IX9nPKaV0fqCm
Content-Type: multipart/alternative; boundary="p95poh5S23vXESWONq6c"

--p95poh5S23vXESWONq6c
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Steven,

Thanks for the fix!
I've tried your patch with a minor fix as attached.
1=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A03=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4
Build Duration:=C2=A0 =C2=A0 =C2=A0 =C2=A0 00:05:51=C2=A0 00:03:47=C2=A0 0=
0:05:15=C2=A0 00:04:31
AutoGen Duration:=C2=A0 00:03:32=C2=A0 00:03:08=C2=A0 00:03:14=C2=A0 00:03=
:16
Make Duration:=C2=A0 =C2=A0 =C2=A0 =C2=A000:01:50=C2=A0 00:00:16=C2=A0 00:=
01:29=C2=A0 00:00:50
GenFds Duration:=C2=A0 =C2=A000:00:30=C2=A0 00:00:22=C2=A0 00:00:31=C2=A0 =
00:00:23

1: clean build with patch and --hash
2: incremental build
3. clean build without patch and without --hash
4. incremental build

BTW, this data cannot compare with previous data I provided because they a=
re built in different environment.

In general, the result is as you said that it fix --hash functionality, bu=
t not as quick as before.
Also the cost of --hash in clean build is increased.

--p95poh5S23vXESWONq6c
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi Steven,<br /><br />Thanks for the fix!<br />I've tried your patch with a=
 minor fix as attached.<br />&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbs=
p; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &n=
bsp; &nbsp; &nbsp;1&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; 2&nbsp; &nbsp;=
 &nbsp; &nbsp; &nbsp; &nbsp;3&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbs=
p; &nbsp; 4<br />
<div>
<div>Build Duration:&nbsp; &nbsp; &nbsp; &nbsp; 00:05:51&nbsp; 00:03:47&nb=
sp; 00:05:15&nbsp; 00:04:31</div>
<div>AutoGen Duration:&nbsp; 00:03:32&nbsp; 00:03:08&nbsp; 00:03:14&nbsp; =
00:03:16</div>
<div>Make Duration:&nbsp; &nbsp; &nbsp; &nbsp;00:01:50&nbsp; 00:00:16&nbsp=
; 00:01:29&nbsp; 00:00:50</div>
<div>GenFds Duration:&nbsp; &nbsp;00:00:30&nbsp; 00:00:22&nbsp; 00:00:31&n=
bsp; 00:00:23</div>
</div>
<br />1: clean build with patch and --hash<br />2: incremental build<br />=
3. clean build without patch and without --hash<br />4. incremental build<b=
r /><br />BTW, this data cannot compare with previous data I provided becau=
se they are built in different environment.<br /><br />In general, the resu=
lt is as you said that it fix --hash functionality, but not as quick as bef=
ore.<br />Also the cost of --hash in clean build is increased.

--p95poh5S23vXESWONq6c--

--bjDrB15IX9nPKaV0fqCm
Content-Type: application/octet-stream; name="build.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="build.patch"

RnJvbSA3ODVmMTA1YjZhZTY1ODI5OTZjYjFkYjM2ZjE4MmQ3OTY3Mjk1OTBjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBEZXJlayBMaW4gPGRlcmVrLmxpbjJAaHBlLmNvbT4KRGF0ZTog
RnJpLCAyNyBTZXAgMjAxOSAxNDowNjowNCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFJlbW92ZSBn
TW9kdWxlQnVpbGRUcmFja2luZwoKLS0tCiBCYXNlVG9vbHMvU291cmNlL1B5dGhvbi9BdXRvR2Vu
L0dlbk1ha2UucHkgfCAyIC0tCiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkKCmRpZmYg
LS1naXQgYS9CYXNlVG9vbHMvU291cmNlL1B5dGhvbi9BdXRvR2VuL0dlbk1ha2UucHkgYi9CYXNl
VG9vbHMvU291cmNlL1B5dGhvbi9BdXRvR2VuL0dlbk1ha2UucHkKaW5kZXggNTg0MTU2ZGFiOTcu
LjRlZDQ2ZGU4ODhjIDEwMDc1NQotLS0gYS9CYXNlVG9vbHMvU291cmNlL1B5dGhvbi9BdXRvR2Vu
L0dlbk1ha2UucHkKKysrIGIvQmFzZVRvb2xzL1NvdXJjZS9QeXRob24vQXV0b0dlbi9HZW5NYWtl
LnB5CkBAIC05NjgsOCArOTY4LDYgQEAgZGVmIFByb2Nlc3NCdWlsZFRhcmdldExpc3Qoc2VsZik6
CiAgICAgICAgIGZvciBhRmlsZSBpbiBoZWFkZXJGaWxlRGVwZW5kZW5jeVNldDoNCiAgICAgICAg
ICAgICBpZiBhRmlsZSBpbiBoZWFkZXJGaWxlc0luTWV0YUZpbGVTZXQ6DQogICAgICAgICAgICAg
ICAgIGNvbnRpbnVlDQotICAgICAgICAgICAgaWYgR2xvYmFsRGF0YS5nVXNlSGFzaENhY2hlOg0K
LSAgICAgICAgICAgICAgICBHbG9iYWxEYXRhLmdNb2R1bGVCdWlsZFRyYWNraW5nW3NlbGYuX0F1
dG9HZW5PYmplY3RdID0gJ0ZBSUxfTUVUQUZJTEUnDQogICAgICAgICAgICAgRWRrTG9nZ2VyLndh
cm4oImJ1aWxkIiwiTW9kdWxlIE1ldGFGaWxlIFtTb3VyY2VzXSBpcyBtaXNzaW5nIGxvY2FsIGhl
YWRlciEiLA0KICAgICAgICAgICAgICAgICAgICAgICAgIEV4dHJhRGF0YSA9ICJMb2NhbCBIZWFk
ZXI6ICIgKyBhRmlsZSArICIgbm90IGZvdW5kIGluICIgKyBzZWxmLl9BdXRvR2VuT2JqZWN0Lk1l
dGFGaWxlLlBhdGgNCiAgICAgICAgICAgICAgICAgICAgICAgICApDQo=

--bjDrB15IX9nPKaV0fqCm--