From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 626209417B5 for ; Fri, 5 Apr 2024 13:43:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=K3mOZh2JxMVNwquCXL1COXikiKKQ4JU6RdoFWDgPojw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:Cc:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712324604; v=1; b=ToenGdF1nMHhbWCv2c1eP4OdPiiDeXxPrR2keLU5k9IgQhg/qArT+Ul7PkzYGiZ8Rzw8hZ+4 NnL20dNYZ2+8D2+TffYPA4nkawY6AyxuLOB7aPNd/eyMPffX+YdBxsnUDAa140dRrzua2eOJFTx Mqt0ZmUGToPNPrglvvap2IhwitbhdF85Xlwk+181eEoYJORevSiO//iRgvsWzMpMvOYO623I6em mfmL07+YQUWRhP+UUf5+lZzIqwtDxRc7VyVEqI5EErVdpt3uaXb69gMOP+E9lqeUGc2tlJNNcFi kpXWNjBZ2xUExaX+vHuq0D5l4aEtwrHoT5XSR+OI2nZTQ== X-Received: by 127.0.0.2 with SMTP id G0AYYY7687511x2sTeDiVcoN; Fri, 05 Apr 2024 06:43:24 -0700 X-Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by mx.groups.io with SMTP id smtpd.web10.12204.1712324602745481444 for ; Fri, 05 Apr 2024 06:43:23 -0700 X-Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 7DAAA3F285 for ; Fri, 5 Apr 2024 13:43:19 +0000 (UTC) X-Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343c6bb1f21so1021293f8f.1 for ; Fri, 05 Apr 2024 06:43:19 -0700 (PDT) X-Gm-Message-State: IfBynpFiwymeOeBTmPvTit8Tx7686176AA= X-Received: by 2002:adf:e782:0:b0:343:80d7:6b31 with SMTP id n2-20020adfe782000000b0034380d76b31mr1321155wrm.57.1712324599192; Fri, 05 Apr 2024 06:43:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwS+FnooyA1vint8YDnIFmVvngo0vnmJwYEQQHH97CpCGv4r/QPGB+5K7XnPB+QxH0IKE3xg== X-Received: by 2002:adf:e782:0:b0:343:80d7:6b31 with SMTP id n2-20020adfe782000000b0034380d76b31mr1321142wrm.57.1712324598732; Fri, 05 Apr 2024 06:43:18 -0700 (PDT) X-Received: from [192.168.123.126] (ip-062-143-245-032.um16.pools.vodafone-ip.de. [62.143.245.32]) by smtp.gmail.com with ESMTPSA id o16-20020a056000011000b00343b252b096sm2075104wrx.23.2024.04.05.06.43.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 06:43:16 -0700 (PDT) Message-ID: <13a091b1-b861-4e38-8ae3-ba9a46fc3536@canonical.com> Date: Fri, 5 Apr 2024 15:43:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses To: phillip@axleos.com References: <20240405125855.48427-1-phillip@axleos.com> Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Gerd Hoffmann From: "Heinrich Schuchardt" In-Reply-To: <20240405125855.48427-1-phillip@axleos.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 05 Apr 2024 06:43:23 -0700 Resent-From: heinrich.schuchardt@canonical.com Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ToenGdF1; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 05.04.24 14:58, phillip@axleos.com wrote: > From: Phillip Tennen >=20 > UsbMouseDxe was missing from the OVMF build description, so > the Simple Pointer Protocol wasn't usable from within QEMU. >=20 > Here's an example of somone getting tripped up by this: > https://forum.osdev.org/viewtopic.php?f=3D1&t=3D31572. >=20 > I worked around this by including the below patch in my local > builds, and was encouraged by Heinrich Schuchardt to submit a patch. >=20 > I have not contributed to this project before, so please accept > my apologies if I've formatted anything incorrect. All the best. >=20 > Signed-off-by: Phillip Tennen >=20 > --- > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfPkgX64.fdf | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 56c920168d..d76a263859 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -953,6 +953,7 @@ > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf Thank you Phillip for your contribution. https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions=20 provides some guidance for contributing. Currently applying the patch fails: $ git am --keep-cr /tmp/\[PATCH\]\ OvmfPkg\:\ OVMF\ supports\ USB\=20 mouses\ -\ phillip@axleos.com\ -\ 2024-04-05\ 1458.eml warning: quoted CRLF detected Applying: OvmfPkg: OVMF supports USB mouses .git/rebase-apply/patch:14: trailing whitespace. MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf .git/rebase-apply/patch:26: trailing whitespace. INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf error: patch failed: OvmfPkg/OvmfPkgX64.dsc:953 error: OvmfPkg/OvmfPkgX64.dsc: patch does not apply error: patch failed: OvmfPkg/OvmfPkgX64.fdf:342 error: OvmfPkg/OvmfPkgX64.fdf: patch does not apply Patch failed at 0001 OvmfPkg: OVMF supports USB mouses I guess this is due to line endings. Please, run 'python3 BaseTools/Scripts/SetupGit.py' in your git=20 repository to set it up to match the Tianocore submission style, e.g. [sendemail] transferEncoding =3D 8bit Please, align to the existing indentation. For consistency it would be preferable to add both lines in the same=20 place under UsbKbDxe.inf. The change looks correct and the USB mouse works fine when testing with=20 your IRC application. File Maintainers contains the list of people that should be CCed on=20 mails with OvmfPkg patches. Best regards Heinrich > =20 > !include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc > =20 > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index eb3fb90cb8..bfe201a352 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -342,6 +342,7 @@ INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > +INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > =20 > INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117458): https://edk2.groups.io/g/devel/message/117458 Mute This Topic: https://groups.io/mt/105348119/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-