From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 37BE8AC0BC9 for ; Fri, 5 Jan 2024 04:38:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZTQ3f87InUpH+ZEEbC5usYnfGGixEri7ZlegIrz2S+Y=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704429517; v=1; b=mlo6KXuc94T7L7kG6HhERQBNmZWczIM6kcaECvn0ncp9XT8m9GxcAD9ecFV/Sz2pNI3gGsSU U+b0Jy6Xdkzj327EjMEyIj3zSqMozICA5r27iUhjs5ZrYie8ZbhsuiCHYMMdw2ue9e6Mo3cuzLL OiB1nil3ymEpLUnnwLezfKYA= X-Received: by 127.0.0.2 with SMTP id ALIJYY7687511xfAMQ5Wq2we; Thu, 04 Jan 2024 20:38:37 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.119]) by mx.groups.io with SMTP id smtpd.web10.17218.1704429517251432356 for ; Thu, 04 Jan 2024 20:38:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MFSSFQjsk4eLZuevFj6DGvaRUiKqwXxeb0L825egZr1rnaqex0HdHh7DibOKpNHYDVmKoJ0mNjyXloS5mKCe7qqKf/cCZ4I1c+La1qNfvj5GxwafW/YYHfiPeO0QeBh/e1CrEfnaLhujuEtUAYAX4JHWBiod+gq6MAvttCgLUui877wYf9OwHFeC+UwCaH0NBKduPePef/BNIHAMDtlG8Qzel3Oxx3SYTVM01s2ZOuYOfS6Vf+33sScwW9gti2kg48cXf8t3KNKC4IeQ2LF47I1lESopo2G1x7vmT0GgrlNZ+ItGktSiErFXiecoD6PVzyPUtkXwcAKlJQDBEXNkGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pez4OpHd3KIbQ3XDwPg9dxC8NT5gud+re3dfB5f7ru0=; b=Bu2nW2aXMPIlTDG9mHdFo0RKfX1DIKjIU/g/TIEhv6jexDttgrGL0wqpbuU5skzyJa2Zcf75TD6SoL6yin2bHocAF28DJNkhRUMJQq3nUB8WUTh4RzKh7aRuPluKE12+1CDsDDjjcUuopJFSbca609GxUVxmUe6ZMLU+kOwq+5DQYN/xnLifdYRnyjI1+4FUJvMJU+sm8yEP9TutDyRGJ8XA14J4pjgGQ9lj3RzbmA77Fj20uThOoLtEQBZ1ESR5f5x5Y3gxTt0uHIkYGIlQRYunYQBsvNkOJYxp8/CR6LWrBcUH2ktNjtEwFvuNuoDV4LmESOAGLzxkvEJJD1Yp5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by SA0PR01MB6220.prod.exchangelabs.com (2603:10b6:806:e2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.13; Fri, 5 Jan 2024 04:38:35 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7159.013; Fri, 5 Jan 2024 04:38:35 +0000 Message-ID: <13a4469f-5c75-43a3-bf0b-1d4b2ec83640@os.amperecomputing.com> Date: Thu, 4 Jan 2024 21:38:34 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 2/3] ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe To: Ard Biesheuvel Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , devel@edk2.groups.io References: <20240103204353.361541-1-rebecca@os.amperecomputing.com> <20240103204353.361541-3-rebecca@os.amperecomputing.com> From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH2PR07CA0049.namprd07.prod.outlook.com (2603:10b6:610:5b::23) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|SA0PR01MB6220:EE_ X-MS-Office365-Filtering-Correlation-Id: 65694584-dd0e-4761-78b9-08dc0da82dd3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: eeUyEtR3m1+S3YgoJYwqad8F2hdhr0EQgvGhQEDNmuIQJsnHPLd+xez6UmxtUDiDQBg4nCd2e3wpnHgBaNFkvZPUYz6tnfGfAhSJUo2aZgBEnrcp6AW5sjpCvVAAaoEkCINTSGR3FIEZnKH6ttdPrlRAMRM2LxeRvgQcQ+tbehhf52Rq7noqlQjvZA1jK7Udh5pXuMcd94gDSXlhBk08VoESQ5n6rozGlFVGNex/vq2QJ5LbO5uYIlGzk/VSJy8fgGiqF+Ow6ISjrnzrbwjvTfwHYr8jkzQYDYWn9klgghMV3R4pLD0YXeoxE0enRwaMLZ/W/ZkOfNmyyfbCpEeG2/U6Rfqs+dYSSiMy6w42J0UofwPe/eX9TY55hnI1J2V8sOV6gVpQ7jngmf3HBEvrbXmr8vNLD7FnWCUvtGdUNHm59YukzgH+2gAmmh5q5pcvfc0JxcNJ34EWMezATPr4ROfoGBTx8lRXGOAVusX7pCA2iILNnBMxf/8URbNT+1vFHcYCYVeKnWgygXEnssDbcFHsLckqQo0xc2tTzrZ+3gvjdn2B562s3HR5A2EfLh854l7sYdpJSNsBYtyBXUA6WT+je2WONJSznBYiI9dSrd0ZUqqw2HDSfKoipuvMMl/A X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnBSRnRaRFcxRjl2TG9YTHdhYTRjQUhvRVJZaWgzMFlnZTI1KzluZWNKSGJ6?= =?utf-8?B?cVArUXEzY3QzL3FyWFRFejRrYktKeks0RFdWL2tjZTVOTVc4RmJLQWpVNU5H?= =?utf-8?B?eGRmZFVUMGx5aWtQZkVGb1Evb0dmODE5YlRYSDdOWVIvUDRYQ3J3NzQvMlJX?= =?utf-8?B?WVFCWmpxb0VzaHEvZjFCSzN5bEl4UFZnRUJNZS9FRDU4eThQYi80WVA1UDhn?= =?utf-8?B?ckdObTIyc2NyclJzMG53MkRIejZuYnFieTd6VHJ5MmhyREJGSm14QkZVRmlQ?= =?utf-8?B?V3N2b0JDWjRzNjV6eFRYb3NmSW9hMHgySTVIR1RER2t4OE5oUXBiVVV5dkQ2?= =?utf-8?B?RVhWQlpVdzJma0ErcUJQMTFxWGxZN09ZMk4rTUVoYXg1dGdTdUQvQWhRQTJn?= =?utf-8?B?NEQwM041Q2s4VU9lOFd1K2hDay9FZkh1QnhnMzFmT01nQlZaWU1PL3BObkpK?= =?utf-8?B?M0JMK1o3cWVjZjFVQVl4OWhTVXpya0tUYyt1UnJDMUtVbklzcGFvMXpvVGc2?= =?utf-8?B?RElPT3BSUldmbVF0cDIvcFVSOVljL2tleDRnZkJEc1RUQXgzYTRHTWU4SVNu?= =?utf-8?B?Qmc1RWJZeElxcHNCR1FvK1AwdXZHc0l5Qnc1eGhGam1oam1XbVV0OXgrdnVE?= =?utf-8?B?Sk1aTFAvU0pRM0hDdWh3bEpPaG84VmN3OFZjeVg5OVprdUs3cWNLMVY3TlhL?= =?utf-8?B?Z2RqM1JIcyt2Z3kwSGsxMTNEeG1ZRW11ZVhPcFd5RFlPK0ZaZVNEeStHQkdr?= =?utf-8?B?b0E1ZXUxMTdnVkFUUTZiMGRBWXo4NTFLY0pnQ3dGdExOa3paUXJnU3hDdTNa?= =?utf-8?B?ZFdFSkFkWXpwS2dMU2hMS1JqMitjUC9WRTc5YVdFQ0h6dk1PZ25BRk4zdmVw?= =?utf-8?B?ZzFmK291ZmMzaGtuWUl2OE9wSGg3T2l6MitTSVl0WVBDSDE4ZjBLeWtuYmFR?= =?utf-8?B?T2NVT3hhc0x3ZWk1QU1RanhaK2ErRS9CbzkzNGp0Z2lGbllmbXBzbWMrdFY5?= =?utf-8?B?d0tvTmh5Ui90ZUEzUWxFSEE4NVE3MGV2alE2ck0xT1oyN3BJSkFyckZFOTk5?= =?utf-8?B?NTdCSndPUHgvVVZYWWs5Q0dGUzBDWVpqa2xycWZPSTVRcUlEM3NhVENSNXpJ?= =?utf-8?B?MkZLZUhpOFg4WHFyaTI4a1pRV1FHMXRCWk9EUWE4Z3NPNEVBQ2tqNTIweVo5?= =?utf-8?B?NWRTRXV5blMwRjlBSkFKNjlSOGE1R3RnY0VVTmtkc1B4bmxsYm1CQ1R6WmJn?= =?utf-8?B?YjY1bjRkdnpKNkprNjIvSDJJRmpHK2syOThLY1AreWNLcnlDN3NHbDViSU1T?= =?utf-8?B?Mm5qNEF5b3k1Ykd5OWhJNmRBL05GN2puTThVR0RzSC9GazY1TkpBTlhmUlZR?= =?utf-8?B?ME5PcURpcFVyN2hHTy9hdVJTNzdOYStwaGh2ZU1TZDJxZ3hrWFBacVl0T1pX?= =?utf-8?B?UllWc0NUMW41R0loeUlpUmdLdFAvMVd6NWJzTDNGMWR0WXVNTnErcW9tQ0hw?= =?utf-8?B?UnI2Q3o1cExSZjRPbG9xZCtCWkV3ZnpsSTJldWx6cHlxSFIrZ1ZPa0pEVS9X?= =?utf-8?B?elV6bHN1MmMrKzlYNGZKNlN1WHFuNkV5bHVKV2poSWhpMnlpVERLUjBwSUhx?= =?utf-8?B?VVcreTZzM25KRnVFNnczNzdNY3UwM1hnRE5YNXljTUhNRGZWS2NkVXBrZ1NN?= =?utf-8?B?UkFpbkVmcGZ6WTYzZWw4QjRKTW0vTGlGTllEeVJhRXBFeXdwMWlQRlpQWmsv?= =?utf-8?B?Zng0TGJXNUxsR0s2Yms3KzlxSncwYzBFcmtDMytZelZsR045ZWlZRGgyNXJo?= =?utf-8?B?WlcwdUNiZ3g4S2VsL2MvNlh6NVpid1V1M0NXMGlZbmw0eGYzK0g3RktXUjhU?= =?utf-8?B?SVF2czQ2S004ZjNlY3JWSFVYNm1JbFloWnU2NmFJWWpNakZmeFVReitUeEMz?= =?utf-8?B?dGo2cE5NbmE3bHYwTkdvSlZKeXlKcjRKblBCbWN2VWsvb1l4NGU1ZUo2T0lp?= =?utf-8?B?THdlYW8wb2ZyZktXbXdWTWVvaEltTWpRTTZ5WVRCMmt1QXd3dTJDekZCSDNG?= =?utf-8?B?NVFZRkNMRGk3QzNhVjVUdUgzVDVtVTIwb3UvbUowQUtYMWtKdlI0Mm5BbDRY?= =?utf-8?B?L0JnM1NKdzVnMHdoeXdFbnFQeWROZE40WjVNTHpib2VxK2V4YW12NkpKbkYz?= =?utf-8?Q?XSo4aM7zlgnXuALfIbKsuzE=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65694584-dd0e-4761-78b9-08dc0da82dd3 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 04:38:35.4931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 14WLV5NOvzD2xvAnvSczJju+0eX56TdKj1vzFBdrQBUnEgDdrwtjnYEqvVR0wgBQmElZxDwbfvMMFMg9kbJIjxnkwLwA4xC8adlPsYXwZW+PCcnHwCQPqQmqiuTgGZ4K X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6220 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wJHbLEuA9m0CqkmCSPzul78Mx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mlo6KXuc; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Thanks, I've incorporated the changes into the v2 patch series. --=20 Rebecca On 1/3/2024 3:56 PM, Ard Biesheuvel wrote: > Hi Rebecca, >=20 > On Wed, 3 Jan 2024 at 21:44, Rebecca Cran > wrote: >> >> Fix the calculation of the timer period in GenericWatchdogDxe: we need >> to multiply before dividing to keep the values as integers. >> >> Signed-off-by: Rebecca Cran >> --- >> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c b/Ar= mPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c >> index 05df101d5f4b..8f02f38c64e3 100644 >> --- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c >> +++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c >> @@ -119,7 +119,7 @@ WatchdogInterruptHandler ( >> // the timer period plus 1. >> // >> if (mWatchdogNotify !=3D NULL) { >> - TimerPeriod =3D ((TIME_UNITS_PER_SECOND / mTimerFrequencyHz) * mNum= TimerTicks); >> + TimerPeriod =3D ((TIME_UNITS_PER_SECOND * mNumTimerTicks) / mTimerF= requencyHz); >=20 > Could we just store the timer period in a global mTimerPeriod, and get > rid of mNumTimerTicks entirely? AFAICT, that would get rid of these > calculations as well. >=20 >> mWatchdogNotify (TimerPeriod + 1); >> } >> >> @@ -260,7 +260,7 @@ WatchdogGetTimerPeriod ( >> return EFI_INVALID_PARAMETER; >> } >> >> - *TimerPeriod =3D ((TIME_UNITS_PER_SECOND / mTimerFrequencyHz) * mNumT= imerTicks); >> + *TimerPeriod =3D ((TIME_UNITS_PER_SECOND * mNumTimerTicks) / mTimerFr= equencyHz); >> >> return EFI_SUCCESS; >> } >> -- >> 2.34.1 >> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113214): https://edk2.groups.io/g/devel/message/113214 Mute This Topic: https://groups.io/mt/103510102/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-