public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, leif.lindholm@linaro.org
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
	Liming Gao <liming.gao@intel.com>, Andrew Fish <afish@apple.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [RFC PATCH 0/3] add GetMaintainer.py helper script
Date: Thu, 20 Jun 2019 17:16:01 +0200	[thread overview]
Message-ID: <13c2a1a6-36ee-55c9-b068-112df365ceab@redhat.com> (raw)
In-Reply-To: <20190614202121.18952-1-leif.lindholm@linaro.org>

Hi Leif,

On 06/14/19 22:21, Leif Lindholm wrote:
> Changes are available directly from:
> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc
> 
> This series adds new tags to the Maintainers.txt format, making it possible
> to describe which filesystem paths are looked after by which people, and
> hence automating the extraction of a list over who should be cc:d on a patch
> submission.
> 
> Remaining shorcomings in RFC:
> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines
>   interspersed with the tag lines. These lines will be removed as areas of
>   responsibility is formally rewritten as tags.
> - * Wildcard support is not fully filesystem compliant except in first or
>   last position in the path (it translates as regex .* elsewhere). However,
>   actual cases of mismatch are expected to be unlikely, and they will be
>   false positives rather than false negatives - so I think this is good
>   enough at least for a start.
> - Provides no information of why certain people or meiling lists were
>   picked - it just bundles all recipients up, deduplicates them, and prints
>   them out.
> 
> Using the script requires the gitpython module to be installed.
> 
> Changelog:
> rfc:
> - Split patches up
>   - one for new Maintainers.txt format (documentation and F: tags).
>   - one for adding a new wilcards responsibility area for */Arm, */AArch64
>   - one for the GetMaintainer.py script
> - Reworked wildcard handling based on Laszlo's explanation
>   - Trailing / covers everything under that directory
>   - Trailing * does not cover subdirectories
> - Added support for X: tag
> - Added support for magic '<default>' pathname
> - Also prints mailing list addresses for matching L: tags
> 
> Leif Lindholm (3):
>   Maintainers.txt: update for filesystem area descriptions
>   Maintainers.txt: add wildcard path association for Arm/AArch64
>   BaseTools: add GetMaintainer.py script
> 
>  BaseTools/Scripts/GetMaintainer.py | 181 +++++++++++++++++++++++++++++++++++++
>  Maintainers.txt                    |  58 ++++++++++++
>  2 files changed, 239 insertions(+)
>  create mode 100644 BaseTools/Scripts/GetMaintainer.py
> 

the series was not posted with correct threading. No need to resubmit
the series just for that (for my sake anyway), but please fix up the
config for any future postings.

Thanks
Laszlo

      parent reply	other threads:[~2019-06-20 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 20:21 [RFC PATCH 0/3] add GetMaintainer.py helper script Leif Lindholm
2019-06-15  6:21 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-06-20 15:16 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13c2a1a6-36ee-55c9-b068-112df365ceab@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox