From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 08:16:27 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BA95130C31A7; Thu, 20 Jun 2019 15:16:06 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F7D55D71C; Thu, 20 Jun 2019 15:16:02 +0000 (UTC) Subject: Re: [edk2-devel] [RFC PATCH 0/3] add GetMaintainer.py helper script To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: "Feng, Bob C" , Liming Gao , Andrew Fish , Michael D Kinney , "Wu, Hao A" References: <20190614202121.18952-1-leif.lindholm@linaro.org> From: "Laszlo Ersek" Message-ID: <13c2a1a6-36ee-55c9-b068-112df365ceab@redhat.com> Date: Thu, 20 Jun 2019 17:16:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190614202121.18952-1-leif.lindholm@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 20 Jun 2019 15:16:16 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Leif, On 06/14/19 22:21, Leif Lindholm wrote: > Changes are available directly from: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc > > This series adds new tags to the Maintainers.txt format, making it possible > to describe which filesystem paths are looked after by which people, and > hence automating the extraction of a list over who should be cc:d on a patch > submission. > > Remaining shorcomings in RFC: > - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag lines > interspersed with the tag lines. These lines will be removed as areas of > responsibility is formally rewritten as tags. > - * Wildcard support is not fully filesystem compliant except in first or > last position in the path (it translates as regex .* elsewhere). However, > actual cases of mismatch are expected to be unlikely, and they will be > false positives rather than false negatives - so I think this is good > enough at least for a start. > - Provides no information of why certain people or meiling lists were > picked - it just bundles all recipients up, deduplicates them, and prints > them out. > > Using the script requires the gitpython module to be installed. > > Changelog: > rfc: > - Split patches up > - one for new Maintainers.txt format (documentation and F: tags). > - one for adding a new wilcards responsibility area for */Arm, */AArch64 > - one for the GetMaintainer.py script > - Reworked wildcard handling based on Laszlo's explanation > - Trailing / covers everything under that directory > - Trailing * does not cover subdirectories > - Added support for X: tag > - Added support for magic '' pathname > - Also prints mailing list addresses for matching L: tags > > Leif Lindholm (3): > Maintainers.txt: update for filesystem area descriptions > Maintainers.txt: add wildcard path association for Arm/AArch64 > BaseTools: add GetMaintainer.py script > > BaseTools/Scripts/GetMaintainer.py | 181 +++++++++++++++++++++++++++++++++++++ > Maintainers.txt | 58 ++++++++++++ > 2 files changed, 239 insertions(+) > create mode 100644 BaseTools/Scripts/GetMaintainer.py > the series was not posted with correct threading. No need to resubmit the series just for that (for my sake anyway), but please fix up the config for any future postings. Thanks Laszlo