Hi Ilias,<br /><br />On Sat, Mar 13, 2021 at 10:31 AM, Ilias Apalodimas wrote:<br />
<blockquote>+ NumBytes =3D NumLba * Instance-&gt;BlockSize;=0D<br />+ Base =3D (VOID *)Instance-&gt;MemBaseAddress + Start * Instance-&gt;BlockSiz=<br />e;=0D<br />+ Buf =3D AllocatePool (NumLba * Instance-&gt;BlockSize);=0D<br />+ if (Buf =3D=3D NULL) {=0D<br />+ return EFI_DEVICE_ERROR;=0D<br />+ }=0D<br />+ SetMem64 (Buf, NumLba * Instance-&gt;BlockSize, ~0UL);=0D<br />+ // Write the device=0D<br />+ Status =3D ReadWriteRpmb (=0D<br />+ SP_SVC_RPMB_WRITE,=0D<br />+ (UINTN)Buf,=0D<br />+ NumBytes,=0D<br />+ Start * Instance-&gt;BlockSize=0D<br />+ );=0D<br />+ if (EFI_ERROR (Status)) {=0D</blockquote>
I think there is a memory leak here as Buf is not freed. If you agree, I will fix this locally before merging the changes.<br />
<blockquote>+ return Status;=0D<br />+ }=0D<br />+ // Update the in memory copy=0D<br />+ SetMem64 (Base, NumLba * Instance-&gt;BlockSize, ~0UL);=0D<br />+ FreePool (Buf);=0D<br />+ }=0D<br />+=0D<br />+ VA_END (Args);=0D<br />+=0D<br />+ return EFI_SUCCESS;=0D<br />+}=0D</blockquote>
Regards,<br /><br />Sami Mujawar