From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [edk2-devel] [RFC PATCH v1 06/30] ArmVirtPkg: Add Arm CCA Realm Service Interface Library To: Sami Mujawar ,devel@edk2.groups.io From: "Sami Mujawar" X-Originating-Location: Cambridge, England, GB (217.140.106.52) X-Originating-Platform: Mac Safari 16.4 User-Agent: GROUPS.IO Web Poster MIME-Version: 1.0 Date: Thu, 04 May 2023 05:59:36 -0700 References: <20230425160428.27980-7-sami.mujawar@arm.com> In-Reply-To: <20230425160428.27980-7-sami.mujawar@arm.com> Message-ID: <14190.1683205176605524473@groups.io> Content-Type: multipart/alternative; boundary="vLREpjryDkL8bYVmoVCN" --vLREpjryDkL8bYVmoVCN Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 25, 2023 at 09:04 AM, Sami Mujawar wrote: >=20 > +/** RSI interface Version > + See Section B4.4.3, RMM Specification, version A-bet0. > + The width of the RsiInterfaceVersion fieldset is 64 bits. > +*/ > +#define RSI_VER_MINOR_MASK 0x00FFULL > +#define RSI_VER_MAJOR_MASK 0x7F00ULL > +#define RSI_VER_MAJOR_SHIFT 16 > + The RSI version masks should have been as below: +#define RSI_VER_MINOR_MASK =C2=A0 0x0000FFFFULL +#define RSI_VER_MAJOR_MASK =C2=A0 0x7FFF0000ULL I will fix these in the next revision. Regards, Sami Mujawar --vLREpjryDkL8bYVmoVCN Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 25, 2023 at 09:04 AM, Sami Mujawar wrote:
+/** RSI interface Version
+ See Section B4.4.3, RMM Speci= fication, version A-bet0.
+ The width of the RsiInterfaceVersion field= set is 64 bits.
+*/
+#define RSI_VER_MINOR_MASK 0x00FFULL
+#= define RSI_VER_MAJOR_MASK 0x7F00ULL
+#define RSI_VER_MAJOR_SHIFT 16+
The RSI version masks should have been as below:
+#define RSI_VER= _MINOR_MASK   0x0000FFFFULL
+#define RSI_VER_MAJOR_MASK   0x7FFF0000ULL

I will fix= these in the next revision.

Regards,

Sami Mujawar --vLREpjryDkL8bYVmoVCN--