From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DF618210DA179 for ; Wed, 8 Aug 2018 11:06:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65F9F40216E8; Wed, 8 Aug 2018 18:06:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-208.rdu2.redhat.com [10.10.120.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 39DE910CD626; Wed, 8 Aug 2018 18:06:36 +0000 (UTC) To: shenglei , edk2-devel@lists.01.org Cc: Eric Dong , Star Zeng References: <20180808084712.34696-1-shenglei.zhang@intel.com> <20180808084712.34696-3-shenglei.zhang@intel.com> From: Laszlo Ersek Message-ID: <141a93ac-e2e0-0987-82ee-3fe4533e84a3@redhat.com> Date: Wed, 8 Aug 2018 20:06:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180808084712.34696-3-shenglei.zhang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 08 Aug 2018 18:06:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 08 Aug 2018 18:06:37 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 02/26] MdeModulePkg UiApp: Remove redundant functions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 18:06:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/08/18 10:46, shenglei wrote: > The functions that are never called have been removed. > They are EnableResetReminderFeature,DisableResetRemin- > derFeature and DisableResetRequired. > https://bugzilla.tianocore.org/show_bug.cgi?id=1062 Please don't split the function names with hyphens. Looks good to me otherwise. The next logical step for UiApp is to remove the IsResetReminderFeatureEnable() function, the "mFeaturerSwitch" variable, and replace all client sites with constant TRUE (and simplify the resultant code). With the commit message updated: Reviewed-by: Laszlo Ersek Thanks Laszlo > > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > --- > MdeModulePkg/Application/UiApp/FrontPage.c | 40 ---------------------- > MdeModulePkg/Application/UiApp/Ui.h | 30 ---------------- > 2 files changed, 70 deletions(-) > > diff --git a/MdeModulePkg/Application/UiApp/FrontPage.c b/MdeModulePkg/Application/UiApp/FrontPage.c > index 2403aad9d9..f0513deb51 100644 > --- a/MdeModulePkg/Application/UiApp/FrontPage.c > +++ b/MdeModulePkg/Application/UiApp/FrontPage.c > @@ -1042,34 +1042,7 @@ UiEntry ( > // > > > -/** > - Enable the setup browser reset reminder feature. > - This routine is used in platform tip. If the platform policy need the feature, use the routine to enable it. > > -**/ > -VOID > -EFIAPI > -EnableResetReminderFeature ( > - VOID > - ) > -{ > - mFeaturerSwitch = TRUE; > -} > - > - > -/** > - Disable the setup browser reset reminder feature. > - This routine is used in platform tip. If the platform policy do not want the feature, use the routine to disable it. > - > -**/ > -VOID > -EFIAPI > -DisableResetReminderFeature ( > - VOID > - ) > -{ > - mFeaturerSwitch = FALSE; > -} > > > /** > @@ -1087,19 +1060,6 @@ EnableResetRequired ( > } > > > -/** > - Record the info that no reset is required. > - A module boolean variable is used to record whether a reset is required. > - > -**/ > -VOID > -EFIAPI > -DisableResetRequired ( > - VOID > - ) > -{ > - mResetRequired = FALSE; > -} > > > /** > diff --git a/MdeModulePkg/Application/UiApp/Ui.h b/MdeModulePkg/Application/UiApp/Ui.h > index a9c30b0c56..7be164570c 100644 > --- a/MdeModulePkg/Application/UiApp/Ui.h > +++ b/MdeModulePkg/Application/UiApp/Ui.h > @@ -53,27 +53,7 @@ typedef struct { > // > //The interface functions related to the Setup Browser Reset Reminder feature > // > -/** > - Enable the setup browser reset reminder feature. > - This routine is used in a platform tip. If the platform policy needs the feature, use the routine to enable it. > > -**/ > -VOID > -EFIAPI > -EnableResetReminderFeature ( > - VOID > - ); > - > -/** > - Disable the setup browser reset reminder feature. > - This routine is used in a platform tip. If the platform policy does not want the feature, use the routine to disable it. > - > -**/ > -VOID > -EFIAPI > -DisableResetReminderFeature ( > - VOID > - ); > > /** > Record the info that a reset is required. > @@ -87,16 +67,6 @@ EnableResetRequired ( > ); > > > -/** > - Record the info that no reset is required. > - A module boolean variable is used to record whether a reset is required. > - > -**/ > -VOID > -EFIAPI > -DisableResetRequired ( > - VOID > - ); > > /** > Check whether platform policy enables the reset reminder feature. The default is enabled. >