From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id B21A9211616A2
 for <edk2-devel@lists.01.org>; Tue,  2 Oct 2018 04:57:46 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com
 [10.5.11.24])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 36E8EC04B2C7;
 Tue,  2 Oct 2018 11:57:46 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-142.rdu2.redhat.com
 [10.10.120.142])
 by smtp.corp.redhat.com (Postfix) with ESMTP id DD569308BDA2;
 Tue,  2 Oct 2018 11:57:44 +0000 (UTC)
From: Laszlo Ersek <lersek@redhat.com>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>
Cc: michael.d.kinney@intel.com, jordan.l.justen@intel.com,
 edk2-devel@lists.01.org, Anthony Perard <anthony.perard@citrix.com>
References: <20181002083602.581-1-marcandre.lureau@redhat.com>
 <dd12fa16-462d-63f2-1be9-dd3065a3ebfa@redhat.com>
 <CAJ+F1C+5gWMWMX4OGXA1gyPirFRa-dYZZDXybmnSWD48OPmWNQ@mail.gmail.com>
 <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com>
Message-ID: <14247590-b301-49d2-429d-042158dac09e@redhat.com>
Date: Tue, 2 Oct 2018 13:57:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <7c3751e8-5870-5769-3db8-bfeed0cb5bac@redhat.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Tue, 02 Oct 2018 11:57:46 +0000 (UTC)
Subject: Re: [PATCH v2 1/1] OvmfPkg/PlatformPei: clear CPU caches
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 11:57:46 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit

On 10/02/18 13:55, Laszlo Ersek wrote:
> On 10/02/18 13:37, Marc-André Lureau wrote:
>> On Tue, Oct 2, 2018 at 2:55 PM Laszlo Ersek <lersek@redhat.com> wrote:
> 
>>> Please fix your git settings for your local edk2 clone. Your patch
>>> contains context lines with LF (not CRLF) line endings, and that's not
>>> correct for edk2.
>>
>> Shouldn't it be catched by: python BaseTools/Scripts/PatchCheck.py -1 ?
> 
> Yes, it should be caught by "PatchCheck.py". The "force_crlf" member is
> set iff the pathname doesn't end in ".sh", and then the
> check_added_line() method verifies CRLF.
> 
> I don't know why it doesn't work in practice. Can you submit a TianoCore
> BZ about it?

Nevermind:

> You are right, the attachment looks fine.

... so that's the reason "PatchCheck.py" does not complain.

Thanks
Laszlo