From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 449AB940F00 for ; Fri, 14 Feb 2025 01:54:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dT1wZu4/UUr7d45vdR1PqnQd/Eo8giCRwL96YUs+MGU=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1739498084; v=1; x=1739757283; b=lJDxTqVbRTBER0crbmePNzgzwQcFeVCrBaxrEBVvya7UmWEHSjQSEjoiLNRof6A6wXMVee7l g6gwi1+wYk5McDAE9SDyIEPl1kD6o92YaqDXVAw39hg4tZfmE/SfwK1sVpXa3hyvtj1rSocPQpi 8ourb7sCB778JKh4DhTvnvXhDbkvPhU6xMYxDhghCfhGx8S2ndRs4EJzxMtlb4ZZANRD5GUHvo0 KW7B4OpjL3yrWivLNCWwFEqLOYKVWWEmoMF72XqZ8JGAmLFcdsyKFKliI2PTwQT1dmXpvVQ/PY3 fimjMAowlJdjKj8qOvRv60LOGuSYzJ779zI1eACdlCrvg== X-Received: by 127.0.0.2 with SMTP id JGApYY7687511x0uSFUSHatZ; Thu, 13 Feb 2025 17:54:43 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.11099.1739498082784612375 for ; Thu, 13 Feb 2025 17:54:42 -0800 X-Received: from [10.6.0.181] (unknown [20.39.63.6]) by linux.microsoft.com (Postfix) with ESMTPSA id F3633203F3EA; Thu, 13 Feb 2025 17:54:41 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F3633203F3EA Message-ID: <14280867-ac0c-4517-b336-3ddd88530606@linux.microsoft.com> Date: Thu, 13 Feb 2025 20:54:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] MOV64 and CLANGPDB To: devel@edk2.groups.io, leif.lindholm@oss.qualcomm.com Cc: Ard Biesheuvel References: From: "Michael Kubacki via groups.io" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 13 Feb 2025 17:54:42 -0800 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NaR8mxp2FDCCaH2hVqmsXsJsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=lJDxTqVb; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io That worked. Let me know what you'd like to do with=20 https://github.com/tianocore/edk2/pull/10760. --- Before (original code) ...ModuleEntryPoint.iiii:58:12: error: immediate must be an integer in=20 range [0, 65535]. movz x9, (-1) >> 48, lsl #48 ; movk x9, ((-1) >> 32) & 0xffff, lsl #32 ;=20 movk x9, ((-1) >> 16) & 0xffff, lsl #16 ; movk x9, (-1) & 0xffff --- After (new code) svc #0 movz x9, ((-1) >> 48) & 0xffff, lsl #48 ; movk x9, ((-1) >> 32) &=20 0xffff, lsl #32 ; movk x9, ((-1) >> 16) & 0xffff, lsl #16 ; movk x9,=20 (-1) & 0xffff cmp x0, x9 cset x0, ne mov x9, xzr ret --- On 2/13/2025 5:33 PM, Leif Lindholm via groups.io wrote: > I would very much like to have a MOV64 that's universally usable. > That's sort of the point. >=20 > However, I'm wondering if the error is in fact triggered by the first > stanza (movz), which doesn't mask its result, and will have 48 sign > extended bits above the ones we care about for the instruction. >=20 > Annoyingly I cannot reproduce the build error in my setup, so I can't > verify if that is the problem. >=20 > Michael, could you possibly do a test and change > movz Reg, (Val) >> 48, lsl #48 ; \ > to > movz Reg, ((Val) >> 48) & 0xffff, lsl #48 ; \ >=20 > on line 51 in MdePkg/Include/AArch64/AsmMacroLib.h ? >=20 > And then rebuild the MOV64 version of ArmStandaloneMmCoreEntryPoint? >=20 > / > Leif >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121120): https://edk2.groups.io/g/devel/message/121120 Mute This Topic: https://groups.io/mt/111172486/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-