public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: PierreGondois <pierre.gondois@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platforms 3/5] Silicon/Hisilicon/FlashFvbDxe: Update TokenSpace of PcdNorFlashCheckBlockLocked
Date: Thu, 26 Jan 2023 03:19:20 -0800	[thread overview]
Message-ID: <14393.1674731960575477221@groups.io> (raw)
In-Reply-To: <20230125102802.663790-4-Pierre.Gondois@arm.com>

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

Hi Pierre,

Thank you for this patch.

On Wed, Jan 25, 2023 at 02:28 AM, PierreGondois wrote:

> 
> --- a/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
> +++ b/Silicon/Hisilicon/Drivers/FlashFvbDxe/FlashFvbDxe.inf
> @@ -25,6 +25,7 @@ [Packages]
> MdePkg/MdePkg.dec
> MdeModulePkg/MdeModulePkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec

[SAMI] I believe the above line can be removed. Can you check, please?
With that addressed.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

> 
> + Platform/ARM/ARM.dec
> Silicon/Hisilicon/HisiPkg.dec
> =20

[-- Attachment #2: Type: text/html, Size: 710 bytes --]

  reply	other threads:[~2023-01-26 11:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 10:27 [PATCH edk2-platforms 0/5] Build fixes for Arm/Hisilicon platforms PierreGondois
2023-01-25 10:27 ` [PATCH edk2-platforms 1/5] Platform/ARM/SgiPkg: Remove '-march=armv8-a+nofp' flag PierreGondois
2023-01-26  9:34   ` Thomas Abraham
2023-01-27  9:01   ` [edk2-devel] " Sami Mujawar
2023-01-25 10:27 ` [PATCH edk2-platforms 2/5] Platform/StandaloneMm: " PierreGondois
2023-01-26  9:35   ` Thomas Abraham
2023-01-26  9:52     ` Ilias Apalodimas
2023-01-27  9:02   ` [edk2-devel] " Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 3/5] Silicon/Hisilicon/FlashFvbDxe: Update TokenSpace of PcdNorFlashCheckBlockLocked PierreGondois
2023-01-26 11:19   ` Sami Mujawar [this message]
2023-01-25 10:28 ` [PATCH edk2-platforms 4/5] Platform/Hisilicon: Add VariableFlashInfoLib to Hisilicon.dsc.inc PierreGondois
2023-01-26 11:31   ` [edk2-devel] " Sami Mujawar
2023-01-26 11:59     ` Sami Mujawar
2023-01-25 10:28 ` [PATCH edk2-platforms 5/5] Platform/ARM/Sgi: Add VariableFlashInfoLib to SgiPlatformMm.dsc.inc PierreGondois
2023-01-26  9:36   ` Thomas Abraham
2023-01-27  9:03   ` [edk2-devel] " Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14393.1674731960575477221@groups.io \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox