public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nhi Pham" <nhi@os.amperecomputing.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com,
	chuong@os.amperecomputing.com, quic_llindhol@quicinc.com,
	Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com,
	Ben.Adderson@arm.com, nd@arm.com
Subject: Re: [PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming
Date: Thu, 14 Jul 2022 10:34:53 +0700	[thread overview]
Message-ID: <143bd56e-98ee-6467-717b-c4a983be136a@os.amperecomputing.com> (raw)
In-Reply-To: <20220712144047.3080-10-sami.mujawar@arm.com>

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,
Nhi

On 12/07/2022 21:40, Sami Mujawar wrote:
> The IORT Specification E.d updates the IORT table revision to 5. To
> reflect this change the IORT header file has been updated to rename
> the EFI_ACPI_IO_REMAPPING_TABLE_REVISION macro which was at Rev 0 to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
>
> Therefore, update the usage of EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> macro in the IORT table for SynQuacer platform to
> EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00.
>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>   Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
> index 97be85c51f253422851ba139ee60bc8fc681aa87..958708810a4918b1683ecc5fb021b59a7191e207 100644
> --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
> +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiIort.c
> @@ -87,7 +87,7 @@ EFI_ACPI_6_0_IO_REMAPPING_TABLE mIortHeader = {
>     .Header = __ACPI_HEADER (
>                 EFI_ACPI_6_0_IO_REMAPPING_TABLE_SIGNATURE,
>                 AC01_IO_REMAPPING_STRUCTURE,
> -              EFI_ACPI_IO_REMAPPING_TABLE_REVISION
> +              EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00
>                 ),
>     .NumNodes = 0,  // To be filled
>     .NodeOffset = sizeof (EFI_ACPI_6_0_IO_REMAPPING_TABLE),

  reply	other threads:[~2022-07-14  3:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 14:40 [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 01/12] Platform/ARM: FVP: Update for IORT revision macro renaming Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 02/12] Platform/ARM: Morello: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 03/12] Platform/ARM: SGI: " Sami Mujawar
2022-07-14 12:30   ` Thomas Abraham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 04/12] Silicon/AMD/Styx: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 05/12] Silicon/Socionext/SynQuacer: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 06/12] Platform/RaspberryPi: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 07/12] Platform/ARM: N1SDP: " Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib Sami Mujawar
2022-07-14  3:34   ` Nhi Pham
2022-07-14  7:40     ` Sami Mujawar
     [not found]     ` <1701A22D591971D9.31468@groups.io>
2022-07-14  9:06       ` [edk2-devel] " Sami Mujawar
2022-07-14  9:12         ` Nhi Pham
2022-07-12 14:40 ` [PATCH edk2-platforms v3 09/12] Platform/Ampere: JadePkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-14  3:34   ` Nhi Pham [this message]
2022-07-12 14:40 ` [PATCH edk2-platforms v3 10/12] Silicon/Phytium: Add VariableFlashInfoLib Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 11/12] Silicon/Phytium: FT2000-4Pkg: Update for IORT revision macro renaming Sami Mujawar
2022-07-12 14:40 ` [PATCH edk2-platforms v3 12/12] Platform/LeMaker: Fix missing dependency on VariablePolicyHelperLib Sami Mujawar
2022-07-13 13:18 ` [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro PierreGondois
2022-07-14  6:38   ` [edk2-devel] " Masahisa Kojima
2022-07-14  8:01     ` Sami Mujawar
2022-07-14  8:06       ` Sami Mujawar
2022-07-14  8:43       ` Masahisa Kojima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=143bd56e-98ee-6467-717b-c4a983be136a@os.amperecomputing.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox