From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.4425.1587730967688502290 for ; Fri, 24 Apr 2020 05:22:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OmhSiUOn; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587730966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PtmiBCUyVi6Le5cmFgzT8VSGlVt7gK5M3aUXhus9GZE=; b=OmhSiUOnPcYXsYrxwih18ChClPcJhL7OX4osFkTWEmkQ+f7+lIbbJ9wUEY9CrqbLC9CyX+ 0djwh0GeqK72vfbSOYowE+ZxnCRhWBJoYXqFGuq33Bf3N3v+HjerpZXE/CgN4KuqtZTYqm s+GP0yzlrDp00oEK9scGbhU7F/8IBrE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-258-zsfGYg9_N9-ci54FC-kH7w-1; Fri, 24 Apr 2020 08:22:40 -0400 X-MC-Unique: zsfGYg9_N9-ci54FC-kH7w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 76D2E107ACCD; Fri, 24 Apr 2020 12:22:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-159.ams2.redhat.com [10.36.113.159]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9AAAD6084A; Fri, 24 Apr 2020 12:22:36 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 4/6] Add BhyvePkg, to support the bhyve hypervisor To: Rebecca Cran Cc: devel@edk2.groups.io, Jordan Justen , Ard Biesheuvel , Leif Lindholm , Michael Kinney , Andrew Fish , Peter Grehan References: <20200421030955.114850-1-rebecca@bsdio.com> <20200421030955.114850-5-rebecca@bsdio.com> <11ec0993-f602-ea9c-6288-ce2d13f6b205@redhat.com> <02A78AC1-573F-4C7A-8466-5EA8885A3195@bsdio.com> From: "Laszlo Ersek" Message-ID: <143ef5ab-49a8-713c-62c1-02ebd6e3a4fd@redhat.com> Date: Fri, 24 Apr 2020 14:22:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <02A78AC1-573F-4C7A-8466-5EA8885A3195@bsdio.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/24/20 07:54, Rebecca Cran wrote: >=20 >> On Apr 23, 2020, at 3:42 AM, Laszlo Ersek wrote: >> >> BUt, I *think* the language seen in "OvmfPkg/License.txt" should >> accommodate that too. It goes: >> >> Some files are subject to the following license, the [...] license. >> Those files are located in: >> - [directory] >> - [directory] >> >> It says "some files", and where they are. It doesn't seem to imply that >> *all* files under those directories are covered by the non-default licen= se. >> >> So please just list all those module directories in this (non-default) >> part of "BhyvePkg/License.txt" that have *at least one* file covered by >> "BSD-2-Clause". >=20 >=20 > Would it also be ok to use the following language? >=20 > Some files are subject to the following license, the BSD-2-Clause license= . > Those files are located in: >=20 > AcpiPlatformDxe/Bhyve.c > PlatformPei/MemDetect.c > PlatformPei/Platform.c probably "located *at*" (not "in"), if we are listing the files themselves. And yes, this is entirely OK, as long as you can collect those files individually! > I think I=E2=80=99ve fixed the rest of the changes you=E2=80=99ve request= ed. I=E2=80=99m ready to send the v4 series once I get clarification about = whether I should add my own copyright line to files I=E2=80=99ve copied fro= m OvmfPkg and made no changes to, or only deletions or other very minor cha= nges. I've attempted to answer that under your other email. Thanks! Laszlo