From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D4622097E262 for ; Thu, 12 Jul 2018 01:51:15 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id q4-v6so27504022iob.2 for ; Thu, 12 Jul 2018 01:51:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=G8K8+i5OGKQkOfS7ncSIf9IiL/rQCh8k0EuE1otjTRo=; b=Ra5RcvLqiWTZPVZIGBfRnICL7xcZxBoo0/UVojyqaQn1C3Pd/Gm9DIFDjm6rv4WSJ1 Wb0DhYGZaOVUPJf3D36q/U47Fj+B7xWF2ddCNNSbI3nMYOLleBG6HZV2moCzPutW+djd arFBCWRZH2KG5NMnQRYolM5U/vuxu7N63XpLw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=G8K8+i5OGKQkOfS7ncSIf9IiL/rQCh8k0EuE1otjTRo=; b=W/nH4pLB4DZq70wsFoxhAVVp7DdL0VtCPss/Eff4pNYz8z6bcF2DSogmW+89pixSoB 5A6Q3k2IEaRIkZ0Xq0nTNOknPozvsf7Q42yOkvXX09xDmpzDwj/XH0VUOdWehAK96+1t 7K4uTe9l6nt/Xt9OU/h6eX/glwonDQpw0PK4lr2mFsYEAPOvGEfgqaii4Y5TbX9yUtz2 y6X/2mIpePm5v2c3qfDem9/01coql/e4i+ubZ3ZHVFc9sErg+VFjxRFTDD2HXur3aDUk GbUwMrr5laiyK5c7K0zJJKC0EtloP3qt/83F6y0ymDd8/TbAtdFcL+0KT05uWyjjSOm6 lpwQ== X-Gm-Message-State: AOUpUlHTlagFTHA1UW5nFz/gTJT1VmIDfC9ju6LvrZYQ68tiEFSYmlaB iWotXZE62/pa5YSfRGSezRTeQQ== X-Google-Smtp-Source: AAOMgpcKDVWpiikjT/E42ZqoWj2Iw4P0ixK2y1vatJYku/Aa+7Ro1J5a8mlYdcaCCUyrJtYX2x/17A== X-Received: by 2002:a6b:1e46:: with SMTP id e67-v6mr1611145ioe.549.1531385475089; Thu, 12 Jul 2018 01:51:15 -0700 (PDT) Received: from [10.118.1.166] ([64.64.108.139]) by smtp.gmail.com with ESMTPSA id v199-v6sm2484983itb.18.2018.07.12.01.51.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Jul 2018 01:51:14 -0700 (PDT) To: Ard Biesheuvel Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo References: <20180704075117.7427-1-ming.huang@linaro.org> <20180704075117.7427-2-ming.huang@linaro.org> From: Ming Message-ID: <1443c4db-6b50-c971-9e18-2b052a19515a@linaro.org> Date: Thu, 12 Jul 2018 16:50:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 08:51:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit 在 11/07/2018 22:19, Ard Biesheuvel 写道: > On 4 July 2018 at 09:51, Ming Huang wrote: >> The edk2 commit bacfd6e let CpuDxe running latter. >> CpuDxe is needed by gDS->SetMemorySpaceAttributes, and >> gDS->SetMemorySpaceAttributes is invoked by some drivers. >> >> This issue can solve by adding Depex on gEfiCpuArchProtocolGuid >> to RealTimeClockLib. >> > > If this is the case, why do we still need the APRIORI DXE section? > This APRIORI DXE will be removed in V3. The new PciHostBridge which is developed by Heyi.Guo will add in V3. Thanks. >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> Signed-off-by: Heyi Guo >> --- >> Platform/Hisilicon/D03/D03.fdf | 4 ++++ >> Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf | 2 ++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf >> index 1383aa1091..73e2b7e958 100644 >> --- a/Platform/Hisilicon/D03/D03.fdf >> +++ b/Platform/Hisilicon/D03/D03.fdf >> @@ -146,6 +146,10 @@ READ_STATUS = TRUE >> READ_LOCK_CAP = TRUE >> READ_LOCK_STATUS = TRUE >> >> + APRIORI DXE { >> + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> + } >> + >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >> >> diff --git a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf >> index 319c35c724..ae7116dc31 100644 >> --- a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf >> +++ b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf >> @@ -46,3 +46,5 @@ >> >> [Pcd] >> >> +[Depex] >> + gEfiCpuArchProtocolGuid >> -- >> 2.17.0 >>