public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: marcandre.lureau@redhat.com, devel@edk2.groups.io
Cc: simon.hardy@itdev.co.uk, stefanb@linux.ibm.com
Subject: Re: [PATCH v3 0/6] Ovmf: enable TPM 1.2
Date: Wed, 26 Feb 2020 11:55:55 +0100	[thread overview]
Message-ID: <144a367f-1ec8-cb7c-4df6-8ef6b10004da@redhat.com> (raw)
In-Reply-To: <6525c251-a85b-26c6-4e2e-9b24a1860ed0@redhat.com>

On 02/26/20 11:47, Laszlo Ersek wrote:
> On 02/26/20 10:34, marcandre.lureau@redhat.com wrote:
>> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> Hi,
>>
>> The following patches add basic TPM 1.2 support for Ovmf/QEMU.
>>
>> Tested successfully Win10 with TIS/TPM 1.2 & CRB/TPM 2.0 passthrough,
>> and emulated CRB/TPM 2.0.
>>
>> v3:
>>  - send a TPM 1.2 command to test TPM version
>>  - split the "Ovmf: enable TPM 1.2 support" patch, mirroring the TPM
>>    2.0 commits
>>
>> Marc-André Lureau (6):
>>   OvmfPkg: rename TPM2 config prefix to TPM
>>   OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei
>>   OvmfPkg: include TcgPei module
>>   OvmfPkg: include TcgDxe module
>>   OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe
>>   OvmfPkg: add TCG Configuration menu to the Device Manager menu
>>
>>  OvmfPkg/OvmfPkgIa32.dsc                  | 39 ++++++++----
>>  OvmfPkg/OvmfPkgIa32.fdf                  | 10 +--
>>  OvmfPkg/OvmfPkgIa32X64.dsc               | 39 ++++++++----
>>  OvmfPkg/OvmfPkgIa32X64.fdf               | 10 +--
>>  OvmfPkg/OvmfPkgX64.dsc                   | 39 ++++++++----
>>  OvmfPkg/OvmfPkgX64.fdf                   | 10 +--
>>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf |  3 +
>>  OvmfPkg/Tcg/Tcg2Config/Tcg2ConfigPeim.c  | 81 +++++++++++++++++++-----
>>  8 files changed, 168 insertions(+), 63 deletions(-)
>>
> 
> I'm very happy with this series. I'd suggest posting v4 quickly (the
> updates should be minimal), so that Simon's testing can concentrate on
> v4. With Simon's feedback in place, I could merge v4 soon after
> edk2-stable202002 is tagged
> <https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning>.

When you post v4, please also push it to a public repo/branch somewhere,
so that Simon can fetch it more easily, for testing.

Thanks!
Laszlo


      reply	other threads:[~2020-02-26 10:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  9:34 [PATCH v3 0/6] Ovmf: enable TPM 1.2 marcandre.lureau
2020-02-26  9:34 ` [PATCH v3 1/6] OvmfPkg: rename TPM2 config prefix to TPM marcandre.lureau
2020-02-26  9:34 ` [PATCH v3 2/6] OvmfPkg: detect TPM 1.2 in Tcg2ConfigPei marcandre.lureau
2020-02-26 10:37   ` Laszlo Ersek
2020-02-26 14:02   ` Stefan Berger
2020-02-26  9:34 ` [PATCH v3 3/6] OvmfPkg: include TcgPei module marcandre.lureau
2020-02-26 10:37   ` Laszlo Ersek
2020-02-26  9:34 ` [PATCH v3 4/6] OvmfPkg: include TcgDxe module marcandre.lureau
2020-02-26 10:40   ` Laszlo Ersek
2020-02-26  9:34 ` [PATCH v3 5/6] OvmfPkg: plug DxeTpmMeasureBootLib into SecurityStubDxe marcandre.lureau
2020-02-26 10:41   ` Laszlo Ersek
2020-02-26  9:34 ` [PATCH v3 6/6] OvmfPkg: add TCG Configuration menu to the Device Manager menu marcandre.lureau
2020-02-26 10:46   ` Laszlo Ersek
2020-02-26 14:29     ` [edk2-devel] " Marc-André Lureau
2020-02-26 10:47 ` [PATCH v3 0/6] Ovmf: enable TPM 1.2 Laszlo Ersek
2020-02-26 10:55   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=144a367f-1ec8-cb7c-4df6-8ef6b10004da@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox